Video Embed

[m3lnic]

No fullscreen button. Also, redirects by pressing name at top.

[tjenkinson]

The full screen button missing is because you need to add

• allowfullscreen
• webkitallowfullscreen
• mozallowfullscreen

attributes.

Adding ?showHeading=0 should remove the heading

https://github.com/LA1TV/Website/blob/master/docs/Embeddable%20Player.md

[tjenkinson]

Actually showHeading currently only works for ?flush=0.

This could be fixed by making this variable https://github.com/LA1TV/Website/blob/43c623454e8bd5bd169ea9c887418c1d92883072/app/controllers/embed/EmbedController.php#L105 false if $showHeading is false

[m3lnic]

Adding the options didn't work.

Currently working on a deployment system so you can see what we are on about.

Have I added the options correctly here?

[tjenkinson]

No the player settings are query parameters so need seeing to the URL like ?option1=1&option2=2 etc.

The disableFullscreen shouldn't be needed. I guess the full screen attributes aren't being set for some reason through react. You could check by inspecting the element in dev tools.

I'm guessing in react it might need to be enableFullScreen or enableFullscreen etc

[tjenkinson]

Actually this made me realise as well as need to support the same URL to an item as the current site so that links from embeds in other places still go to the right place on the new site :)