search

LABSN / expyfun

Experimental paradigm functions.
BSD 3-Clause "New" or "Revised" License
13 stars 21 forks source link

FIX: Expyfun package requirements #431

Closed NeuroLaunch closed 2 years ago

NeuroLaunch commented 2 years ago

When updating the UW lab's expyfun environment I ran into an issue where a pyglet method was not found. Specifically, .glMatrixMode was not recognized during a call to exp_controller_module. Apparently the issue arises from changes in pyglet's support of OpenGL, whereby glMatrixMode and other methods have been deprecated.

@drammock has suggested specifying pyglet < 2.0 in the package setup (I had success downgrading to pyglet 1.5.18) or updating expyfun to support the recent versions of pyglet and OpenGL.

larsoner commented 2 years ago

The current stable release is 1.5.18, and indeed 2.0-flavor (which are currently in prerelease phase) are not supported. We'll have to refactor drawing once 2.0.0 is actually released.

NeuroLaunch commented 2 years ago

Sorry, I may have jumped the gun then. I had run a 'conda update conda', which may have changed the pyglet version; alternatively, I see our stim computer has a clone of the pyglet repo so the 2.0 version may have been pulled in. (I'm still getting used to the expyfun coding environment.)

On Tue, Aug 17, 2021 at 8:57 AM Eric Larson @.***> wrote:

The current stable release is 1.5.18, and indeed 2.0-flavor (which are currently in prerelease phase) are not supported. We'll have to refactor drawing once 2.0.0 is actually released.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LABSN/expyfun/issues/431#issuecomment-900420861, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWJWA4POPHJZ4WBLOVI4UDT5KBE7ANCNFSM5CCFMW5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

larsoner commented 2 years ago

If using the pyglet repo you want to be on the 1.5-maintenance branch, not main/master (which has 2.0-dev)

larsoner commented 2 years ago

@NeuroLaunch can you make a PR to update https://github.com/LABSN/expyfun/blob/main/doc/getting_started.rst to tell people to use pyglet-1.5-maintenance rather than master if they're going that route? This also got @JustinTFleming recently

NeuroLaunch commented 2 years ago

@larsoner Yes, I can do that.