search

LABSN / expyfun

Experimental paradigm functions.
BSD 3-Clause "New" or "Revised" License
13 stars 21 forks source link

ec.refocus sets window topmost #447

Closed tomstoll closed 1 year ago

tomstoll commented 1 year ago

Added a line in experiment_controller.refocus() which should bring the experiment window to the front and fix #446. Also removed commented out equivalent code from the same function. I quickly tested this on two computers running Windows 10 and one running Windows 7 and didn't notice any issues.

larsoner commented 1 year ago

Argh the CIs haven't run in a while. I think we'll have to ignore / look carefully at the errors to see if they make any sense

tomstoll commented 1 year ago

Ok. I still don't really know what I'm doing on GitHub, but I made sure to sync my fork with the current main branch before making the change in this PR. I'll look at the failed tests.

larsoner commented 1 year ago

I'll look at the failed tests.

They are almost certainly not related to your changes. Over time dependencies can have deprecations and CIs can change things slightly in ways that can change things. We haven't had a PR to expyfun in months, so these are going to cause CIs to fail.

I'll try to fix these first early next week, then we can merge main into this branch and the CIs will be meaningful. Until then, they probably aren't really.

larsoner commented 1 year ago

Marking for merge when green, thanks in advance @tomstoll !