search

LABSN / mnefun

Facilitating lab integration with mne-python
BSD 3-Clause "New" or "Revised" License
6 stars 15 forks source link

Introspection #331

Closed ktavabi closed 3 years ago

ktavabi commented 3 years ago

@larsoner: with these params effectively spanning two different files, how are they ever going to be accessed by introspection?

[mnefun] mnefun/data/canonical.yml (Line 164)


  drop_log:

Open in IDE · Open on GitHub

Created from VS Code using CodeStream

larsoner commented 3 years ago

@larsoner: with these params effectively spanning two different files, how are they ever going to be accessed by introspection?

The YAML gets read and populates params, so in theory the params object should be introspect-able as it was before. Then if you wonder how a particular value got in params, it either got there from the YAML, the Python script, or from the defaults of the class. But if you can eliminate Python almost entirely like we did for funloc, then it effectively limits it to either being from YAML or from the defaults (or as always, maybe a bug in handling somewhere!).

larsoner commented 3 years ago

Okay to close @ktavabi ?