LABSN / mnefun

Facilitating lab integration with mne-python
BSD 3-Clause "New" or "Revised" License
6 stars 15 forks source link

select ct, cal files #362

Closed nordme closed 1 year ago

nordme commented 1 year ago

This is a fix so mnefun selects the correct calibration and cross talk files for running maxfilter in python. This code should: a) preserve the ability of the user to provide custom files either for ct or cal, b) if no custom files are provided, choose whether to use Vectorview or Triux files based on raw.info['description'] (which encodes which machine was used to record the raw file).

nordme commented 1 year ago

@drammock So, I haven't run checks like pyflakes, etc yet, but I just went ahead and opened the PR so you can see it

larsoner commented 1 year ago

I was thinking of selecting based on info['meas_date'] but as long as we don't mess with 'description' during acquisition (which I think you can in principle but we probably don't in practice) I think this is fine. We can always change to another method later if needed so +1 for this method if it works for you @nordme !

drammock commented 1 year ago

needs merge with main to pass CIs. I'm getting Permission denied even though it looks like the "maintainers may edit" box is checked. @nordme could you pull my flake8 fix, merge in upstream/main, then push?

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@be55c99). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage        ?   19.99%           
=======================================
  Files           ?       33           
  Lines           ?     5161           
  Branches        ?        0           
=======================================
  Hits            ?     1032           
  Misses          ?     4129           
  Partials        ?        0           
larsoner commented 1 year ago

Just pushed an empty commit to make CircleCI happy, marking for auto-merge when green. Thanks in advance @nordme !

drammock commented 1 year ago

🙏🏻 @nordme!