search

LABSN / tdtpy

Python wrapper around the Tucker-Davis Technologies ActiveX library
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Add long-overdue unit tests #16

Closed bburan closed 3 years ago

larsoner commented 3 years ago

Do you want to add codecov here, too? It's pretty easy to adapt these files/lines I think:

https://github.com/mne-tools/mne-python/blob/main/.coveragerc https://github.com/mne-tools/mne-python/blob/main/codecov.yml https://github.com/mne-tools/mne-python/blob/main/azure-pipelines.yml#L129-L133

bburan commented 3 years ago

@larsoner Are you talking about automating the pytest? The tests will only work on a platform that's connected to a TDT system. Right now only systems with the RZ6 will work, but the tests don't require that other than the fact that the only test circuit I created is compiled against the RZ6. Would there be any benefit to adding codecov given that none of the current tests would work as part of the automated process?

larsoner commented 3 years ago

Oh no, I didn't look that closely and assumed that the circuit maybe somehow had a debug mode where it faked the right responses for tests. Never mind!

larsoner commented 3 years ago

Thanks @bburan

bburan commented 3 years ago

@larsoner It would be a nice feature to have a simulated circuit for debugging. Perhaps someday if I need to do much more work on TDPy I can add that. Thanks for merging this!