Fix version check so that CI tests pass

LABSN / tdtpy

Python wrapper around the Tucker-Davis Technologies ActiveX library

BSD 3-Clause "New" or "Revised" License

7 stars 3 forks source link

Fix version check so that CI tests pass #27

Open bburan opened 1 year ago

bburan commented 1 year ago

https://github.com/LABSN/tdtpy/blob/c7b2eaaec207dd4371749815c7ad3f91243843d5/.github/workflows/tests.yml#L29:L32

  - run: |
      python -c "import tdt; print(tdt.__version__); assert 'dev' in tdt.__version__"
    name: Check versioning
    if: "!contains(github.event.head_commit.message, '[version skip]')"

Is this check still necessary now that we are using setuptools_scm?

larsoner commented 1 year ago

It was actually put there specifically to make sure we don't end up with something bad like 0.0.0 when using setuptools_scm.

It will fail on releases, though, it would be nice to avoid that -- maybe by making it skip that run when on a tag or whatever. Or we just ignore the failure of that step on releases...