search

LABSN / tdtpy

Python wrapper around the Tucker-Davis Technologies ActiveX library
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Enhancements for TDTPy #8

Closed ghost closed 4 years ago

ghost commented 4 years ago

This includes:

ghost commented 4 years ago

Note that these changes were contributed by Decibel Therapeutics, which has asked for acknowledgement of their support. I have added a note to the readme file listing authors/contributors. Please add anyone else I may have left off.

larsoner commented 4 years ago

Code changes LGTM. I do not currently have (easy) access to a TDT to test this. Have you tested these at all @buranconsult ? If not I guess we can trust Decibel to have tested it.

Was the CoInitialize what was required to get threading to work?

ghost commented 4 years ago

I made the changes on behalf of Decibel and can confirm it works fine with some software I wrote for them. The changes were required to get TDT hardware (using TDTPy as a wrapper) working with psiexperiment ( https://github.com/bburan/psiexperiment). Look for a future release of psiexperiment which will then support both National Instruments and TDT hardware (allowing us to write an experiment once and run it on either system -- some limitations apply of course).

CoInitialize was required to get threading to work properly.

On Fri, Mar 6, 2020 at 10:12 AM Eric Larson notifications@github.com wrote:

Code changes LGTM. I do not currently have (easy) access to a TDT to test this. Have you tested these at all @buranconsult https://github.com/buranconsult ? If not I guess we can trust Decibel to have tested it.

Was the CoInitialize what was required to get threading to work?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LABSN/tdtpy/pull/8?email_source=notifications&email_token=AOYD2UCVGECEMC5BAQLMF73RGE4IFA5CNFSM4LDD6QNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOCJWSI#issuecomment-595893065, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOYD2UDOUU63V7WMTC36SI3RGE4IFANCNFSM4LDD6QNA .

larsoner commented 4 years ago

Cool, thanks for filling in the gaps @bburan