search

LABSS / PROTON-OC

Simulation of recruitment to organized crime
MIT License
4 stars 2 forks source link

General cleaning pep8 #15 #241

Closed ambitious-octopus closed 3 years ago

ambitious-octopus commented 3 years ago

This is a gargantuan PR. What are the major changes:

  1. Each function has type hints and a description of what it does.
  2. Unnecessary functions have been deleted (e.g. random_links)
  3. The objects of the model (Person, Employer, Job, School) are now all in the file Person that will change name in the next PR. Proposals for a name: entities.
  4. Static functions have been moved to the extra module (e.g. df_to_dict).
  5. All varibles, functions, and class names follow the pep8 standard.
  6. General formatting respects pep8.

PyLint scores: mesaPROTON-OC.py -> 9.5/10 Person.py -> 8.9/10 extra.py -> 7.5/10 testProton -> 8.9/10