search

LADSoft / OrangeC

OrangeC Compiler And Tool Chain
http://ladsoft.tripod.com/orange_c_compiler.html
Other
291 stars 39 forks source link

Possibly incompatibility between `omake` and `mingw32-make` #933

Closed ghost closed 1 year ago

ghost commented 1 year ago

The way mingw32-make expands variables seems to be different from omake:

https://www.gnu.org/software/make/manual/html_node/Conditional-Syntax.html

From my experience, GNU Make (which mingw32-make is a port of) doesn't like double quotes. Double-quoted variables like those currently used in Orange C's makefiles will not work as expected.

For example: ifneq "$(ORANGEC_ONLY)" "YES". On GNU make I think it should be ifneq ($(ORANGEC_ONLY),YES).

Please correct me if I'm wrong. I'm only a noob to both GNU Make and omake.

Related issue: #932

Update: Yeah. It turns out I'm wrong. ifneq "$(ORANGEC_ONLY)" "YES" is definitely fine with GNU Make.

LADSoft commented 1 year ago

yeah i had to put the quotes in, because, if ORANGEC_ONLY isn't defined and you don't have quotes, the ifneq doesn't have the right number of arguments...