search

LAGonauta / MetaAudio

GoldSrc engine plugin for 3D sound
GNU General Public License v2.0
98 stars 14 forks source link

Port to MetaHookSv and add support for the new HL25 engine #58

Closed hzqst closed 7 months ago

hzqst commented 7 months ago

image

  1. The old metahook (submodule) should be removed, I've added MetaHookSv as a new submodule right aside metahook.
  2. I added set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>") to the CMakeList.txt to make sure the generated dlls are static-linked to the runtime libraries (aka /MT) to get rid of vcredist.
  3. The hook for S_Startup has been commented out because S_Startup has been inlined into S_Init and S_Startup isn't a thing anymore. thus I moved to SNDDMA_Init which basically does the same thing. though I am not sure if there will be any impact to the metaaudio features.
  4. There should be a tutorial / instruction to lead users to install OpenAL32.dll from https://www.openal.org/ or from whatever sources otherwise the game won't launch.
  5. There better be pre-compiled binaries in the release page. You can take advantake of github action runner to build and publish releases on every git push. (just like what I did).
LAGonauta commented 7 months ago

LGTM and it is working! :D

LAGonauta commented 7 months ago

Thank you so much @hzqst