search

LAION-AI / Open-Assistant

OpenAssistant is a chat-based assistant that understands tasks, can interact with third-party systems, and retrieve information dynamically to do so.
https://open-assistant.io
Apache License 2.0
37.04k stars 3.23k forks source link

Implement Celery task for Discord notifications of reports #3517

Closed olliestanley closed 1 year ago

olliestanley commented 1 year ago

The previous implementation caused a bug and so is reverted by #3516

nablabits commented 1 year ago

Hi @olliestanley , I'm happy to give this a try. I've managed to get the dev server running locally and spotted where that button lives and what are the methods called. I have a couple of questions:

Chances are this issue might have a steep learning curve, so if anyone more knowledgeable is keen to pick this up, feel free, I'm happy with the learning experience anyways.

olliestanley commented 1 year ago

Hi @olliestanley , I'm happy to give this a try. I've managed to get the dev server running locally and spotted where that button lives and what are the methods called. I have a couple of questions:

  • Did you revert the previous implementation as a quick fix or rather because it was a dead end? I say so because if it was a quick fix I can reinstate it and debug it.
  • If it was a dead end, do you have in the code base some similar task I can take a look at as a guide?
  • Finally, do you have a discord channel sandbox that I can use to test the messages arriving? Alternatively I can set up something on my own

Chances are this issue might have a steep learning curve, so if anyone more knowledgeable is keen to pick this up, feel free, I'm happy with the learning experience anyways.

I think the previous approach was fine in principle, but there was a bug causing the report function to be broken entirely, and we wanted to fix prod ASAP so just reverted the change.

We don't have a sandbox, you might have to set something up for that unfortunately.

Hopefully this should be a fairly small change so would be great if you could take a look!

nablabits commented 1 year ago

Cool, thanks for the answers, I will work through this these days and will let you know if I get stuck :crossed_fingers: