LAION-AI / Open-Assistant

OpenAssistant is a chat-based assistant that understands tasks, can interact with third-party systems, and retrieve information dynamically to do so.
https://open-assistant.io
Apache License 2.0
36.95k stars 3.23k forks source link

Factor out the dashboard page layout into a shared layout #432

Closed fozziethebeat closed 1 year ago

fozziethebeat commented 1 year ago

Right now website/src/pages/dashboard includes a nice Sidebar with multiple menu options and then presents the select page's contents.

This is a great design that would be nice to use in other scenarios such as for an admin specific page which would have different sidebar options.

To do this I think we need to:

Klotske commented 1 year ago

@fozziethebeat I think I could take this issue. Could you assign it to me? Self-assigning needs Github's Collaborator role i think...

fozziethebeat commented 1 year ago

Great!@ Yeah, the assigning part is a bit of a hassle. After the MVP we might want to have a group discussion about simplifying it.

Also, since this is quite a few changes, I'd request this be done in a couple PRs rather than one giant PR.

AbdBarho commented 1 year ago

could this be closed?