search

LAJW / history-menu

History extension for Webkit-based browsers.
GNU General Public License v3.0
19 stars 3 forks source link

Sometimes Empty #21

Open snakehill opened 1 year ago

snakehill commented 1 year ago

Sometimes, the history shows completely empty: image

This seems to happen at random moments. And then it randomly starts working again later on. The browser history itself is still in tact and fine.

I use it on Opera (101.0.4843.43). I tried both the Opera extension (which shows only a tiny little empty popup) and the Chrome extension (which shows the popup as big as in the image, at the cost of having no favicons when it actually is working).

Default extension settings otherwise. And resetting anything or rebooting the browser doesn't solve the issue, it really just starts working again by itself after a bit.

LAJW commented 1 year ago

Hi, thank you for bug report.

I have trouble with Opera, as they don't review extensions anymore. The fix will be applied only to the Chrome version.

LAJW commented 1 year ago

Are there any opera-specific pages in your history by any chance? The extension parses URLs and when it encounters something odd it can sometimes crash like this. Alternatively, could you right click on it, click inspect and post the red text in the "Console" tab?

snakehill commented 1 year ago

Are there any opera-specific pages in your history by any chance? The extension parses URLs and when it encounters something odd it can sometimes crash like this.

At most the Extensions page (and with the Speed Dial opened too but that one isn't logged), but it has also happened without either.

Alternatively, could you right click on it, click inspect and post the red text in the "Console" tab?

Will do when it happens again. It did just and the very moment I opened Inspect Element it started working without errors showing. Will definitely keep an eye out for it.

The fix will be applied only to the Chrome version.

I don't mind either, of course. It's awesome as is (as long as it's working). The only thing I noticed with the Chrome extension is that favicons don't show up, which I suppose is a separate bug.

Opera extension: opera

Chrome extension: chrome

LAJW commented 1 year ago

Looks like Opera didn't yet implement favicons in their Manifest V3 API (they are 14 versions behind mainline Chrome). There is a workaround, but implementing it would share your entire browsing history with Google whenever you opened the popup on Opera and favicons wouldn't work if you lost your internet connection. Doing this would be against the spirit of this extension (it was always meant to be offline-only).

At the same time the support for favicons in V3 was added in Chromium 104 (Opera is currently on 102). So we can just wait a little and the favicons should start working again without the workaround on the Chrome version.

Manifest V3 extensions were allowed only recently, perhaps this is why my extension wasn't accepted last time 🤔. But I didn't get any feedback when submitting, so I can never be sure.

Sorry for the trouble, I didn't realise there was such a huge version gap between different Chrome forks, I'll be testing more thoroughly from now on.

snakehill commented 1 year ago

Darn, I hope they will update soon then. Otherwise, if it'd be worth it, feel free to implement the workaround in a toggleable fashion with some warning about the history being shared with Google. But no worries either way!

Meanwhile, in both extension versions on Opera, either right-clicking the element or Inspect Element seems to solve the original (emptiness) bug. I'm not sure which action exactly, for I'm too fast going to Inspect Element (out of a habit), but it fixed it 2 out of 2 times now. In case that helps tracking down the culprit (will be more careful next time, or record it if I manage).

snakehill commented 1 year ago

I think it has to do with something in Opera (re)loading something, because I discovered it also happens upon booting the browser (at least it looks the exact same, but those times it fixes itself automatically after a few seconds). So I think at least some "Loading..." indication would come in handy.

When it happens while browsing, with Opera open and active for a while, Inspect Element is what fixes it, somehow initiating the load. So not just right-clicking, and it also does so when initiated through the keyboard shortcut (Ctrl+Shift+C), hovering over the element.

LAJW commented 1 year ago

So I managed to reproduce it somewhat - if you haven't used your browser for a while (empty browsing history), the extension will crash showing an empty white page. This isn't specific to Opera though.