search

LAMPSPUC / StateSpaceModels.jl

StateSpaceModels.jl is a Julia package for time-series analysis using state-space models.
https://lampspuc.github.io/StateSpaceModels.jl/latest/
MIT License
272 stars 25 forks source link

simulate_scenarios for BasicStructuralExplanatory fails if seasonality is not 12 #308

Closed SupplyChef closed 2 years ago

SupplyChef commented 2 years ago

A hard coded value of 14 in src\models\basicstructural_explanatory.jl line 201 assumes that the seasonality is 12.

sys.Z[1][14:end] .= new_exogenous[1, :]

For models with a different seasonality, a dimension mismatch error is thrown (DimensionMismatch("array could not be broadcast to match destination"))

guilhermebodin commented 2 years ago

Hi @SupplyChef thanks for letting us know, I am fixing the issue and will release a new version.

SupplyChef commented 2 years ago

Thank you!