search

LAMPSPUC / StateSpaceModels.jl

StateSpaceModels.jl is a Julia package for time-series analysis using state-space models.
https://lampspuc.github.io/StateSpaceModels.jl/latest/
MIT License
272 stars 25 forks source link

Fix basic structural with exogenous variables simulation #309

Closed guilhermebodin closed 2 years ago

guilhermebodin commented 2 years ago

close #308

raphaelsaavedra commented 2 years ago

Thanks for the quick fix!

We should add a test that catches this issue right? I think just running a simple simulation and checking if the dimensions are correct is enough

codecov[bot] commented 2 years ago

Codecov Report

Merging #309 (2b455cd) into master (bea472c) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   93.04%   93.05%           
=======================================
  Files          35       35           
  Lines        3293     3295    +2     
=======================================
+ Hits         3064     3066    +2     
  Misses        229      229
Impacted Files Coverage Δ
src/models/basicstructural_explanatory.jl 99.00% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bea472c...2b455cd. Read the comment docs.