search

LANDIS-II-Foundation / Extension-Biomass-Harvest

LANDIS extension for simulating the effects of forest management.
https://sites.google.com/site/landismodel/extensions/biomass-harvest
Apache License 2.0
0 stars 10 forks source link

harvest implementation order matters for prescriptions #38

Open meggmaclean opened 5 years ago

meggmaclean commented 5 years ago

The bug is that if the harvest implementation order does not match the prescription order, the prescription that is defined first may run in conjunction with the prescription implemented.

For example, if we create an input text file with:

Prescription A

StandRanking Random

SiteSelection PartialStandSpread 1 20

CohortsRemoved SpeciesList

pinustro 20-500 (20%)

Prescription B

StandRanking Random

SiteSelection PartialStandSpread 1 20

CohortsRemoved SpeciesList

acerrubr 20-500 (20%)

HarvestImplementations

Mgmt Area Prescription Harvest Area Begin Time End Time

     1                   B                                             50%                       1                      10

     1                   A                                             50%                       11                     30

We see that in our first 10 years both prescriptions A and B are implemented (both pinustro and acerrubr are removed). However, if we switch the harvest implementations so that prescription A comes first, only B happens in the first 10 years and A proceeds normally afterward. Possible missing reset to zero of species removal after reading prescriptions? We had a similar issue in LUC that Adam fixed for us.

Current work-around:

If we explicitly call all of our active species in each prescription, all prescriptions proceed normally, no matter the order of implementation.

For example, if we change our text file to include all species in each prescription (even those without removal), everything seems to go as expected:

Prescription A

StandRanking Random

SiteSelection PartialStandSpread 1 20

CohortsRemoved SpeciesList

acerrubr 20-500 (0%)

pinustro 20-500 (20%)

Prescription B

StandRanking Random

SiteSelection PartialStandSpread 1 20

CohortsRemoved SpeciesList

acerrubr 20-500 (20%)

pinustro 20-500 (0%)

HarvestImplementations

Mgmt Area Prescription Harvest Area Begin Time End Time

     1                   B                                             50%                       1                      10

     1                   A                                             50%                       11                     30