LANDIS-II-Foundation / Extension-NECN-Succession

The Net Ecosystem Carbon and Nitrogen extension for the LANDIS-II model.
http://www.landis-ii.org/extensions/net-ecosystem-cn-succession
Apache License 2.0
1 stars 19 forks source link

NECN v6.8 LAI crashing #75

Closed alisondeak closed 2 years ago

alisondeak commented 2 years ago

I recently moved over to the newest version of NECN (v6.8) because earlier versions weren't compatible with the climate library the most recent version of SCRPPLE (v3.2.1) uses. Since moving over, each of the species cohort's LAI and AGB has begun crashing and, and in single-cell simulations the GrowthLimitLAI for each species doesn't budge from 0. I've made multiple attempts at modifying each of the parameters influencing LAI without any change in GrowthLimitLAI or any effects on LAI itself.

NECN_succession.txt NECN-calibrate-log.csv NECN-succession-log.csv NECN_functional_group_params.csv

rmscheller commented 2 years ago

Zachary,

Any thoughts?

alisondeak commented 2 years ago

Ah, Zachary just emailed me - I had only noticed the new minimum LAI parameter and hadn't realized there was the new GrowthLAI parameter which I hadn't added to my functional parameters table. I imagine this is likely the issue.

ZacharyRobbins commented 2 years ago

It would be good if that threw an error. It seems like it is defaulting to zero rather than the traditional 0.47

alisondeak commented 2 years ago

It doesn't seem to be the issue. GrowthLimitLAI is still stuck at 0 );

ZacharyRobbins commented 2 years ago

Redirecting this a little. The problem was resolved for me when moving the NECN species data to a .csv file. The issue is now that the extension does not provide you with an error when you have the data in the NECN succession file, and instead just does not produce leaves .

rmscheller commented 2 years ago

Alison, Removing the previous method of reading in species parameters is the only reasonable fix I have for the problem. As always, having two options for IO 2x+ the programming required! The new version of 6.8 therefore requires that you use a CSV file. Give it a go and I'll update the documentation before the official release... soon, hopefully.

mslucash commented 2 years ago

This issue is solved and could be closed.

rmscheller commented 2 years ago

Thanks!