brmiranda
commented
4 hours ago Clement,
Thanks for making these changes and thinking about how the updated dll needs to be carried into the installers for the extensions. The PnET Cohort Library v2 can be found in the 'v8' branch of the Library-PnET-Cohort repository (v8 for the change to core version 8). I agree that these changes should be applied to v2 of the library. When compiled, this fixed v2 dll should also be pushed to the Support-Library-Dlls-v8 repository, and it should be referenced from there into new compiles of PnET-Succession and PnET-Output. The Support-Library-Dlls-v8 repository serves as the common location for official versions of shared libraries.
Cheers, -Brian
[Forest Service Shield] Brian Miranda (he/him) Senior Analyst Eastern Planning Service Group Forest Service Eastern and Southern Regions 608-461-2966 @.**@.> La Crosse, WI www.fs.usda.govhttp://www.fs.usda.gov/ [USDA Logo]https://usda.gov/ [Forest Service Twitter] https://twitter.com/forestservice [USDA Facebook] https://www.facebook.com/pages/US-Forest-Service/1431984283714112 Caring for the land and serving people
From: Clement Hardy @.> Sent: Thursday, October 10, 2024 3:41 PM To: LANDIS-II-Foundation/Extension-PnET-Succession @.> Cc: Miranda, Brian - FS, WI @.>; Mention @.> Subject: [LANDIS-II-Foundation/Extension-PnET-Succession] Warning : Will surely need to edit the PnET Cohort Library v2.0 to account for a recent fix in v1.0 (Issue #14)
As per the recommendation of @brmirandahttps://github.com/brmiranda , I've proposed a fix to the PnET Cohort Library to fix the faulty computation of a variable (see LANDIS-II-Foundation/Library-PnET-Cohort#2https://github.com/LANDIS-II-Foundation/Library-PnET-Cohort/pull/2 ).
I wanted to re-compile PnET Succession and upgrade the PnET Succession installer so that the latest version can take into account this fix (to avoid problems of wrong versions of the same library overwriting each other during the install of PnET Succession and PnET Biomas Output, for example).
However, I've seen that the current files of the repo call for a version 2.0 of the PnET Cohort Library...which does not exist currently in the PnET Cohort Library repo as of right now. I imagine that one of you has made the PnET Cohort Library 2.0 library locally for testing, on a fork; but has then referenced this non-available library into the main PnET Succession branch. Maybe @aruzicka555https://github.com/aruzicka555 ?
So, I'm a bit at a loss.
I propose to make the following actions as soon as possible to avoid further issues :
- [ ] The fix proposed to v1 of the PnET Cohort Library should be included into v2 (see LANDIS-II-Foundation/Library-PnET-Cohort#2https://github.com/LANDIS-II-Foundation/Library-PnET-Cohort/pull/2)
- [ ] The v2 of the PnET Cohort Library should be made available on the PnET Cohort Library repository (via a pull request, if on a fork)
- [ ] The up-to-date v2 of the PnET Cohort Library should then added to this repo (PnET Succession); the .dll of PnET Succession should be recompiled; and the latest installer (v6) should be updated.
- Reply to this email directly, view it on GitHubhttps://github.com/LANDIS-II-Foundation/Extension-PnET-Succession/issues/14, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACHE7AYRUPL4I2CRLQ6RNFLZ23Q5FAVCNFSM6AAAAABPXSWGYCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU3TSNZZHA2DSNI. You are receiving this because you were mentioned.Message ID: @.**@.>>
This electronic message contains information generated by the USDA solely for the intended recipients. Any unauthorized interception of this message or the use or disclosure of the information it contains may violate the law and subject the violator to civil or criminal penalties. If you believe you have received this message in error, please notify the sender and delete the email immediately.
aruzicka555
Klemet
As per the recommendation of @brmiranda , I've proposed a fix to the PnET Cohort Library to fix the faulty computation of a variable (see https://github.com/LANDIS-II-Foundation/Library-PnET-Cohort/pull/2 ).
I wanted to re-compile PnET Succession and upgrade the PnET Succession installer so that the latest version can take into account this fix (to avoid problems of wrong versions of the same library overwriting each other during the install of PnET Succession and PnET Biomas Output, for example).
However, I've seen that the current files of the repo call for a version 2.0 of the PnET Cohort Library...which does not exist currently in the PnET Cohort Library repo as of right now. I imagine that one of you has made the PnET Cohort Library 2.0 library locally for testing, on a fork; but has then referenced this non-available library into the main PnET Succession branch. Maybe @aruzicka555 ?
So, I'm a bit at a loss.
I propose to make the following actions as soon as possible to avoid further issues :