search

LANDIS-II-Foundation / Extension-SCRPPLE

Social and Climate-driven fire extension.
https://landis-ii-foundation.github.io/Extension-SCRPPLE/
Apache License 2.0
1 stars 10 forks source link

Random ignition not tied to Random seed #138

Closed ZacharyRobbins closed 2 years ago

ZacharyRobbins commented 2 years ago

Ignition is currently tied to the Ether library, meaning it is not impacted by setting a random seed. We'll need to make a branch that works with the Core random number generators to allow for quasi-deterministic runs for calibration.

rmscheller commented 2 years ago

Zachary, was this Tucker who requested the issue?

ZacharyRobbins commented 2 years ago

Yes

rmscheller commented 2 years ago

A new version 3.2.1 ready for testing.

rmscheller commented 2 years ago

Should be ready. I wish I could add tucker-furniss to this conversation!

tucker-furniss commented 2 years ago

The issue appears to be fixed in v3.2.1. Setting a non-random seed in the scenario file will now produce the same fires. Thanks Zachary for posting about the issue and Rob for fixing it!