search

LANDIS-II-Foundation / Extension-Social-Climate-Fire

Social and Climate-driven fire extension.
https://landis-ii-foundation.github.io/Extension-SCRPPLE/
Apache License 2.0
2 stars 11 forks source link

Initial state fuel maps from NECN #133

Closed ZacharyRobbins closed 3 years ago

ZacharyRobbins commented 3 years ago

When running scrapple the initial fuel conditions are not added until the first NECN timestep. This can result in uncalibrated behavior prior to that step. We need to change the order of the assignment to fix this issue.

rmscheller commented 3 years ago

Hm. I thought this would be more straightforward.

L113: https://github.com/LANDIS-II-Foundation/Extension-NECN-Succession/blob/master/src/PlugIn.cs L409: https://github.com/LANDIS-II-Foundation/Extension-NECN-Succession/blob/master/src/utility/ReadMaps.cs

I don't see any logical fallacies there and the layer should be instantiated at the same time as all other layers.

rmscheller commented 3 years ago

I tweaked how NECN shares the Succession.FineFuels parameter and committed a new version of NECN v6.8.

rmscheller commented 3 years ago

I also tweaked SCR* 3.2, cleaning up the interface to Succession.FineFuels.

ZacharyRobbins commented 3 years ago

According to my latest runs, the fine fuels output is the same map at every time step, 24 year run.

rmscheller commented 3 years ago

I have updated the code with new v3.2.