Percent slope treated as degrees in effective wind speed calculation

LANDIS-II-Foundation / Extension-Social-Climate-Fire

Social and Climate-driven fire extension.

https://landis-ii-foundation.github.io/Extension-SCRPPLE/

Apache License 2.0

2 stars 11 forks source link

Percent slope treated as degrees in effective wind speed calculation #153

Closed tgestabrook closed 10 months ago

tgestabrook commented 11 months ago

The SCRAPPLE documentation calls for the ground slope map to consist of "integer values representing percent slope on the ground", but the function to calculate effective wind speed converts from degrees to radians rather than percent to radians:

double slopeRadians = (double)SiteVars.GroundSlope[site] / 180.0 * Math.PI; //convert from Degrees to Radians

Apologies if the percent to degree conversion is made elsewhere and I missed it.

Cheers, Thomas Estabrook

rmscheller commented 10 months ago

Thomas,

After reviewing the code, I'm sure you're right. I'll update the documentation.