LANDIS-II-Foundation / Extension-Social-Climate-Fire

Social and Climate-driven fire extension.
https://landis-ii-foundation.github.io/Extension-SCRPPLE/
Apache License 2.0
2 stars 12 forks source link

Ignitions output problems #35

Closed akretchun closed 7 years ago

akretchun commented 7 years ago

There are 2 problems with the ignitions outputs currently:

1 - All pixels in the map are output as 0, even though ignitions are recorded in the ignitions log file 2- The ignitions log file is misreporting ignition type. I am testing with only lightning ignitions B0, B1 >0, yet the ignitions log is reporting both lightning and accidental ignitions

akretchun commented 7 years ago

Related to problem 2 above, the ignitions output log isn't sensitive to input parameters and prints the same thing every time. There are always 2 attempted ignitions per day for Accidental and Lightning from day 60-335. For Rx, there are always 20 attempted ignitions every year, but not sure why 20. This is all despite only having ignition parameters for Lightning <0

akretchun commented 7 years ago

With respect to those particular julian days, those are the hardcoded month cutoffs in the FWI calcs for months >2 and <12, so every month from March through November

rmscheller commented 7 years ago

I think the ignition map issue has been resolved. There were some odd type conversions. Also patched the log file. Runs to completion but needs more testing.

akretchun commented 7 years ago

Ignitions log file is now responsive to Bo and B1 input parameters, though it still prints out 2 ignitions/day by type if all parameters are set =0. So it always prints our 2 igns/day, but increases if input parameters dictate more ignitions

rmscheller commented 7 years ago

I worked out the math and it seems that 2 per day if B0/B1 = 0 is as expected.

akretchun commented 7 years ago

Ignitions maps still report all 0s despite ignitions being recorded in the log file

rmscheller commented 7 years ago

That's because I'm having difficult getting site severity > 0. I fixed an issue with suppression and also moved the site recording of type and day outside of the severity loop.

rmscheller commented 7 years ago

Fixed.