LANDIS-II-Foundation / Library-Spatial

The library that handles spatial interactions for LANDIS.
Apache License 2.0
0 stars 6 forks source link

premake fails with premake5-alpha12 #14

Closed derekmorr closed 5 years ago

derekmorr commented 6 years ago

I'm trying to build Library-Spatial on OS X. I downloaded premake5-alpha12, but the build fails:

% ~/Downloads/premake5 vs2015

** Warning: the flags value Symbols has been deprecated and will be removed.
   Use `symbols "On"` instead
   @/Users/dvm105/landis/Library-Spatial/src/premake5.lua(14)

** Warning: the flags value OptimizeSize has been deprecated and will be removed.
   Use `optimize "Size"` instead.
   @/Users/dvm105/landis/Library-Spatial/src/premake5.lua(18)

Error: error loading module 'CSProjFile' from file './CSProjFile.lua':
    /Users/dvm105/landis/Library-Spatial/src/CSProjFile.lua:81: invalid escape sequence near '"\.'

If I manually retrieve premake5-alpha11, it works:

% ~/Downloads/premake5-alpha11 vs2015
** Warning: the flags value Symbols has been deprecated.
   Use `symbols "On"` instead
Building configurations...
Running action 'vs2015'...
Generated landis-spatial.sln...
Generated api/Landis_SpatialModeling.csproj...
Generated Landscapes/Landis_Landscapes.csproj...
Generated RasterIO/Landis_RasterIO.csproj...
Generated RasterIO.Gdal/Landis_RasterIO_Gdal.csproj...
Modifying api/Landis_SpatialModeling.csproj ...
  <HintPath> elements added to the project's references
  Enabled the generation of XML documentation file
Modifying Landscapes/Landis_Landscapes.csproj ...
  <HintPath> elements added to the project's references
Modifying RasterIO/Landis_RasterIO.csproj ...
  <HintPath> elements added to the project's references
Modifying RasterIO.Gdal/Landis_RasterIO_Gdal.csproj ...
  <HintPath> elements added to the project's references
Done (38ms).

I think I've also seen this issue with Landis Core.

We should either add a note to the README, or update premake5.lua to fix the issue.

As an aside, why does the project use premake? Is there a reason the .csproj files can't be checked directly into git? They could be build using mono's xbuild or .NET Core's build tools directly w/o needing premake.

rmscheller commented 6 years ago

Derek,

A couple of quick notes:

rmscheller commented 5 years ago

Premake has been retired.