search

LANL-Seismoacoustics / PyGeoTess

Python interface to the GeoTess gridding and earth model library.
https://lanl-seismoacoustics.github.io/PyGeoTess/
Other
3 stars 5 forks source link

Updates #12

Closed rad-lanl closed 4 months ago

rad-lanl commented 4 months ago
rad-lanl commented 4 months ago

Not sure why the pull is attempting to remove geotess/src/EathShape.cc? i'd reject that change if possible Its in my fork? https://github.com/rad-lanl/PyGeoTess/blob/master/geotess/src/EarthShape.cc

jkmacc-LANL commented 4 months ago

We've still got EarthShape.cc. It looks like someone ran a linter on it; there are just a few whitespace changes.

jkmacc-LANL commented 4 months ago

@rad-lanl I don't see GeoTessModel.getPointWeights in the CPP source code; where did this come from?

EDIT: is it just the different calling signatures for GeoTessModel.getWeights? If so, I'd like to (try to) keep one method with the same name but with variable arguments and pass the right stuff to the different underlying getWeights signatures.

RichardAlfaro commented 4 months ago

Yes it’s just calling different signatures of GeoTessModel.getWeights, okay with me to wrap it into a generalized getWeights call

On May 31, 2024, at 2:38 PM, jkmacc-LANL @.***> wrote:



@rad-lanlhttps://github.com/rad-lanl I don't see GeoTessModel.getPointWeights in the CPP source code; where did this come from?

— Reply to this email directly, view it on GitHubhttps://github.com/LANL-Seismoacoustics/PyGeoTess/pull/12#issuecomment-2142946748, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGCUTIZEA5GAAHDQVCP4IWDZFDNT7AVCNFSM6AAAAABID7WPQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBSHE2DMNZUHA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

jkmacc-LANL commented 4 months ago

I'll leave that for a later PR, so you don't have to change code. It should be a straightforward change.