search

LANL-Seismoacoustics / PyGeoTess

Python interface to the GeoTess gridding and earth model library.
https://lanl-seismoacoustics.github.io/PyGeoTess/
Other
3 stars 5 forks source link

First merge request #8

Open rwporritt opened 2 years ago

rwporritt commented 2 years ago

Here's the first push to get most of the functionality together. I have a couple notebooks that we can add too.

jkmacc-LANL commented 2 years ago

This is awesome, Rob. I'm looking it over now.

Pinging @sandyballard505 for visibility.

sandyballard505 commented 2 years ago

I have looked through this and I am not sure I totally get what is going on. I would be happy to participate in a call to discuss the path forward.

There is an extensive set of tests for the c++ and c interfaces. I’ve attached the c++ tests.

Sandy

rwporritt commented 2 years ago

I’ve look through it a couple times and am also a bit overwhelmed. Probably my fault for pushing such a big update.

I’m off tomorrow, but would be happy to chat next week.

sandyballard505 commented 2 years ago

You guys are writing python code to wrap essentially every public c++ method? That would be a lot.

jkmacc-LANL commented 2 years ago

Sounds good, Rob. We can touch base next week.

BTW, it looks like yours and Sandy's GitHub settings are such that the entire body of the emails you're sending are showing up in the conversation of the PR. Further, Sandy, your attachment is stripped so I don't have it:-( I'm going to remove them from your responses on GitHub because it's making the PR page really hard to follow, but I recommend removing the previous email body in your responses or just responding on the PR page.