Error message in testfilter.py

[xichaoqiang]

I try test the package use your example, and get the result of chirp .It seems well.

But I meet two problems in testfilter.py

1. test_instantaneous_azimuth(synthetic_data)

   assert theta[idx_7_5hz, idx_2sec] == pytest.approx(az_retro + 90, abs=TOL)

my result of theta[idx_7_5hz, idx_2sec] =85.4045037740963.

The last three results are correct, so it is very strange.

2.test_scalar_azimuth_prograde(synthetic_data)

assert az == pytest.approx(az_retro + 90, abs=TOL)

My result of az = 329.9997087423515

[jkmacc-LANL]

Hi Xi,

I’m glad you’re finding Particleman interesting. There are two known errors but I haven’t had a moment to work on them. The second one is only 180° off from the expected value, so it could be pretty quick to fix. Are you available to help track it down?

I’ll add a proper CI script shortly, so these errors should be easier to see.

Thanks again!

-Jon

[xichaoqiang]

I’ll add a proper CI script shortly, so these errors should be easier to see.

I‘ll try to track it.I am new to NIP algorithm.These days I am studying Kristel's papers.

[jkmacc-LANL]

@xichaoqiang I've tried to add some CI in GitHub Actions with #3. Those two tests always fail, but the other nine always pass 😜

I'm leaving this open in case you're interested in helping me track down those errors 😄

[xichaoqiang]

Thanks for your reply.