LANL-Seismoacoustics / pisces

Pisces: A practical seismological database library in Python.
http://lanl-seismoacoustics.github.io/pisces/
Other
17 stars 10 forks source link

update _declarative_constructor location #49

Closed cnlg-lanl closed 1 year ago

cnlg-lanl commented 1 year ago

Updated location of _declarative_constructor now located in sqlalchemy.orm.decl_base.py . Tried to leave exception for sqlalchemy 1.3.4 users

jkmacc-LANL commented 1 year ago

@cnlg-lanl That external contributor's PR may have used something other than declarative_base because of the intent of the SQLA authors. Again, maybe we can not worry about it for now, since you've found the original function, and we can just see if it creates any problems.

jkmacc-LANL commented 1 year ago

I think the other change made by the external user may have been to address the items() error we're seeing. Want me to make it, or are you ok to?

cnlg-lanl commented 1 year ago

I'll let you make it and see if that fixes it...doing some research on it as this could be a separate issue. Looking here

From the change_log:

    Deprecated all schema-level ``.copy()`` methods and renamed to
    ``_copy()``.  These are not standard Python "copy()" methods as they
    typically rely upon being instantiated within particular contexts
    which are passed to the method as optional keyword arguments.   The
    :meth:`_schema.Table.tometadata` method is the public API that provides
    copying for :class:`_schema.Table` objects.
cnlg-lanl commented 1 year ago

Working on this now, making the suggested change

cnlg-lanl commented 1 year ago

welp, same problem

jkmacc-LANL commented 1 year ago

Closes #38 .

cnlg-lanl commented 1 year ago

Done

jkmacc-LANL commented 1 year ago

Thanks again, @cnlg-lanl. Huzzah!

cnlg-lanl commented 1 year ago

This also takes care of issue #44