LANL-Seismoacoustics / pisces

Pisces: A practical seismological database library in Python.
http://lanl-seismoacoustics.github.io/pisces/
Other
17 stars 10 forks source link

inventory creation #79

Open cnlg-lanl opened 4 months ago

cnlg-lanl commented 4 months ago

@jkmacc-LANL Thinking I’m going to start working on the inventory creation function in pisces today. Looks like I created a branch but didn’t start on it. Do you have an opinion on whether this goes into the stations.py file or do you think it would be better in it’s own file?

jkmacc-LANL commented 4 months ago

Thanks for asking. On the event side of things, I put the logic for converting query things to Catalog things into a separate file since it feels like it has a separate job. Maybe do it in an inventory.py.

cnlg-lanl commented 4 months ago

Cool. That's what I remembered the plan being, but figured I'd check.

cnlg-lanl commented 4 months ago

@jkmacc-LANL ...I'm digging through the recent obspy updates. It looks like the scaling factor issue in their response file has been fixed in 1.4.1 but not 1.4.0, do we want to make pisces dependent on 1.4.1 since we are adding in response information?