search

LARG / HFO

Half Field Offense in Robocup 2D Soccer
MIT License
231 stars 93 forks source link

setup.py, README.md clarifications; HFO, python_agents_3v3.sh misc improvements; prevention of endless loop for high_level_custom_agent.py #27

Closed drallensmith closed 7 years ago

drallensmith commented 7 years ago

I did a bit of testing and checking, and found that it will definitely run on 2.7 and 3.5 (add others that you've tested locally, of course), but the python HFO script will not run on 3.0 or 3.1 (no argparse module). I have also noted a requirement for numpy.

I've also done a bit of reliability improvements for HFO, and enabled better using python_agents_3v3.sh for testing.

-Allen

drallensmith commented 7 years ago

Due to itertools.count going on forever (weirdly, as noted in the file), and that break in Python only exits the innermost loop, high_level_custom_agent.py never exits, even after the server quits. I have fixed this, and will check for it and fix it in other python agents.

-Allen

mhauskn commented 7 years ago

Thanks for these changes! I've made a couple of in-line comments. Will be happy to merge after comments addressed.

drallensmith commented 7 years ago

Quite welcome. I'm not completely sure if the check for opponent distance for dribbling is needed - doPreprocess in agent.cpp, called by doDribble, seems to be trying to handle this via doForceKick. In the meantime, changed to NOOP as you suggested.

-Allen