LARG / HFO

Half Field Offense in Robocup 2D Soccer
MIT License
231 stars 93 forks source link

"Violated Feature Bounds" errors in high-level feature set; obeying docs+utility vs compatibility #33

Open drallensmith opened 7 years ago

drallensmith commented 7 years ago

When doing test runs of the example agents and using the high-level feature set, I am frequently seeing "Violated Feature Bounds" errors; files are attached below (some of agents/cpp code with other changes). I have traced at least some of these to highlevel_feature_extractor.cpp, where it was not checking for validity of self or ball positions before providing them. By the manual, it should have put in FEAT_INVALID (-2) instead of clamping at the end of the correct range. However, fixing this, such as via the linked code, may break code or, rather worse, trained learners (frequently more difficult to change than code!). This would be especially true if the old code output +1 and the new code output -2. I'm not sure what to do.

-Allen

agent1.old2.txt agent1.pyrandomization.txt agent1.txt agent2.old2.txt agent2.pyrandomization.txt agent2.txt