search

LARG / HFO

Half Field Offense in Robocup 2D Soccer
MIT License
228 stars 93 forks source link

Fixing distances without other (significant) alterations #42

Closed drallensmith closed 4 years ago

drallensmith commented 7 years ago

This is at least a partial solution to #38 - it still uses the maximum distance as being the maximum one within the non-OOB area, admittedly. I have put in a warning in the README.md about code changes necessary - for instance, the SARSA weights will need adjusting - and given an example change in high_level_custom_agent.py.

I have also fixed the low-level distance-to-OOB values; I concluded that "proximity to being OOB in x direction" was a reasonable interpretation, so it will be -1 at and within the appropriate OOB, since that indicates no distance to being OOB - the agent already is... it will, however, correctly scale to only being 1 at the limit of the (OOB) playable area on the opposite side.

mhauskn commented 5 years ago

Hi @drallensmith - this PR fell off my radar but should be merged to master. Can you resolve the merge conflicts and I will merge it?