LASY-org / lasy

https://lasydoc.readthedocs.io
Other
29 stars 23 forks source link

CI: systematically check the values of the fields in the openPMD file #35

Open RemiLehe opened 1 year ago

RemiLehe commented 1 year ago

(related to #34)

Our current CI test only dumps the field to an openPMD file and makes sure that this is not crashing. However, it would be good to check the actual values.

Maybe we could build a template test file that would work for any profile, and then simply loop through our existing profiles and:

MaxThevenet commented 1 year ago

Also related to #23.

KPeterBlum commented 1 year ago
  • Read the openPMD file and check the fields.

What kind of checks to you imagine? In general I can think of something like:

MaxThevenet commented 1 year ago

Yes, these kind of tests would be very useful. No need to test all profiles, so just metadata + some rough physical quantities for a Gaussian profile (mostly checking that e.g. the array does not contain NaNs) would be enough.