search

LAYAIraq / LAYA-Iraq-Frontend

This repository contains the Vue.js frontend of LAYA Iraq. Please read the README for further instructions on installation, testing and development. Further questions or issues may be send to laya-iraq@outlook.com or as an issue via Github.
GNU Lesser General Public License v3.0
1 stars 1 forks source link

Bugfix: Feedback Persistence #240

Open NVieregg opened 2 years ago

NVieregg commented 2 years ago

Checkout branch refactor-feedback.

In its current state, the following input fields are not saved and displayed:

I will continue trying to fix the issue, but any advice or idea about the issue is appreciated!

NVieregg commented 2 years ago

New insight:

Titles and tasks are not displayed on any plugin component (just tested Drag&Drop, Relate and SCMC).

The issue seems to be outside of feedback.

cmauf commented 2 years ago

New insight:

Titles and tasks are not displayed on any plugin component (just tested Drag&Drop, Relate and SCMC).

The issue seems to be outside of feedback.

Have you tested it in a new course? Or the sample courses? If the latter, there might be a version problem. Try deleting the database and rebuild it.

cmauf commented 2 years ago

New insight:

Titles and tasks are not displayed on any plugin component (just tested Drag&Drop, Relate and SCMC).

The issue seems to be outside of feedback.

The issue seems to be as following: When you set "simple language" in course properties, any view.vue renders only the simple version, regardless of user's preferences. Maybe you set 'simpleLanguage' but didn't provide any simple language title? Because otherwise (untick 'simple language' in course preferences), i cannot reproduce the plugins not rendering titles.

cmauf commented 2 years ago

In its current state, the following input fields are not saved and displayed:

* Title (and SimpleTitle)

* Task (and SimpleTask)

this happens because title and task are defined as strings in data. Therefore, they don't have properties simple and text, hence input data is linked to something that doesn't exist. The browser console throws a lot of warnings when you input anything.

* the first two input fields of "Possible Answers" -> if new input fields are generated by clicking the "Add" button, those contents are kept and displayed (please don't ask why, it just works like black coding magic)

I don't understand this issue. I can add more than two answers and they get saved.

* Star Rating doesn't get saved yet

You need to define an event handler that handles the payload of the rating-selected event. The @rating-selected property is a shorthand for that. If you write @rating-selected="e => rating = e", the rating gets saved in component state. This is because we handle the payload (named e to be use d as value for rating). Alternatively, you can call a method handling the payload.