search

LArSoft / larwirecell

This code is part of the Liquid Argon Software (LArSoft) project. It contains simulation and reconstruction algorithms for LAr TPC detectors. If you have a problem, please log a redmine issue: https://cdcvs.fnal.gov/redmine/projects/larsoft/issues/new
0 stars 18 forks source link

Changes to build against art 3.09.01 and with Spack #11

Closed marcmengel closed 1 year ago

marcmengel commented 3 years ago

Changes to build against art 3.09.01 and with Spack

FNALbuild commented 3 years ago

Can one of the admins verify this patch?

brettviren commented 3 years ago

I just noticed this now. FWIW, it looks good to me, though I guess it's all build related.

lgarren commented 3 years ago

@brettviren Thanks Brett. This and related PRs are on hold until we finally update to art 3.09.

FNALbuild commented 3 years ago

A new Pull Request was created by @marcmengel (Marc Mengel) for develop.

It involves the following packages:

larwirecell

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

FNALbuild commented 3 years ago

The code-checks are being triggered in jenkins.

FNALbuild commented 3 years ago

+code-checks
for details see https://buildmaster.fnal.gov/buildmaster/job/GithubIntegration/job/run-pr-code-checks//989/console