LArSoft / larwirecell

This code is part of the Liquid Argon Software (LArSoft) project. It contains simulation and reconstruction algorithms for LAr TPC detectors. If you have a problem, please log a redmine issue: https://cdcvs.fnal.gov/redmine/projects/larsoft/issues/new
0 stars 18 forks source link

Bare use of `new` should be replaced with smart pointer #14

Open brettviren opened 2 years ago

brettviren commented 2 years ago

A few places such as in the depo sources, a bare new is used. The heap object is correctly deleted in the destructor. In this particular case, a unique_ptr would provide a more modern idiom if also identical behavior.

Note that components are held by shared_ptr and those that provide WCT flow graph nodes tend to live for the entire job, in practice.