Empty CMM bugfix + skip frame in FrameSaver

[lynnt20]

CMM bugfix:

• previously, if the FrameSaver was not able to find the configured cmm name or if the cmm was empty, no art product would be created due to the continue; line, leading to an artroot error when running. Updated to allow empty CMMs.

Skip Frame

• add configurable to allow user to skip saving a frame (in other words, not have to save raw::RawDigits or recob::Wire). Default behavior is skip_frame = false, AKA default behavior is to save a frame.

[FNALbuild]

A new Pull Request was created by @lynnt-uchicago for develop.

It involves the following packages:

larwirecell

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

-code-checks Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larwirecell/Components/FrameSaver.cxx \ 
  larwirecell/Components/FrameSaver.h

Then commit the changes and push them to your PR branch.

[FNALbuild]

Pull request #33 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[lgarren]

trigger build

[FNALbuild]

The tests are being triggered in jenkins.

[FNALbuild]

+LArSoft tests OK on slf7 for c7:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20255&builds= +build

[FNALbuild]

+LArSoft tests OK on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20256&builds= +build

[FNALbuild]

-argoneut tests failed on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:argoneut/view_builds/index?offset=0&builds=argoneut_ci/8846&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20256&builds=

[FNALbuild]

-sbnd tests failed on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/12453&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20256&builds=

[FNALbuild]

-icarus tests warning on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/7893&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20256&builds=

[FNALbuild]

-uboone tests warning on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:uboone/view_builds/index?offset=0&builds=uboone_ci/9410&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20256&builds=

[FNALbuild]

-dune tests tests warning on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/15859&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20256&builds=

[lgarren]

@LArSoft/level-2-managers please review and approve or comment

[tomjunk]

Approved

[FNALbuild]

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged.)

[lgarren]

approve