LArSoft / larwirecell

This code is part of the Liquid Argon Software (LArSoft) project. It contains simulation and reconstruction algorithms for LAr TPC detectors. If you have a problem, please log a redmine issue: https://cdcvs.fnal.gov/redmine/projects/larsoft/issues/new
0 stars 18 forks source link

LS changed IDE interface to add an additional "track ID" and it would be nice if sim channel makers provided. #34

Closed brettviren closed 1 year ago

brettviren commented 1 year ago

The current context for making SimChannel is this segment of the processing chain:

art::Event->

  (SimEnergyDeposit)->

[larwirecell] SimDepoSetSource->

  (IDepo)->

[WCT] Drifter->

  (IDepo)->

[larewirecell] DepoSetSimChannelSink->

  (SimChannel)->

art::Event

Probably obvious but ()'s marks data objects, []'s are packages, the rest are code objects.

Two changes are needed:

1) SimDepoSetSource

https://github.com/LArSoft/larwirecell/blob/develop/larwirecell/Components/SimDepoSetSource.cxx#L208

2) DepoSetSimChannelSink:

https://github.com/LArSoft/larwirecell/blob/develop/larwirecell/Components/DepoSetSimChannelSink.cxx#L189

Both of these changes should be made configurable in order to allow old behavior. Eg, SimDepoSetSource and DepoSetSimChannelSink gain a parameter like id_is_depo which would be "true" in the new case and "false" in the old.

brettviren commented 1 year ago

Work on this is happening in https://github.com/brettviren/larwirecell/tree/feature/bv_trackid_torigin

Coding is done and now devising tests.

brettviren commented 1 year ago

Work merged in #35