Closed brettviren closed 1 year ago
A new Pull Request was created by @brettviren (Brett Viren) for develop.
It involves the following packages:
larwirecell
@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.
cms-bot commands are listed here
The code-checks are being triggered in jenkins.
-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules
has been setup and execute the following command from the top-level directory of your repository:
format-code \
larwirecell/Components/DebugDumper.h \
larwirecell/Components/DepoFluxWriter.cxx \
larwirecell/Components/DepoFluxWriter.h \
larwirecell/Components/SimDepoSetSource.cxx \
larwirecell/tests/depofluxwriter/root/collect.C \
larwirecell/tests/depofluxwriter/root/plot.C
Then commit the changes and push them to your PR branch.
Pull request #35 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.
The code-checks are being triggered in jenkins.
+code-checks
trigger build
The tests are being triggered in jenkins.
+LArSoft tests OK on slf7 for c7:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20350&builds= +build
+LArSoft tests OK on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20349&builds= +build
-argoneut tests failed on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:argoneut/view_builds/index?offset=0&builds=argoneut_ci/8897&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20349&builds=
-uboone tests failed on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:uboone/view_builds/index?offset=0&builds=uboone_ci/9462&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20349&builds=
-icarus tests warning, with build warning,, with ignored warning for build, on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/7954&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20349&builds=
-sbnd tests warning, with build warning,, with ignored warning for build, on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/12517&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20349&builds=
-dune tests tests warning on slf7 for e20:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/15948&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20349&builds=
approve
This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged.)
approve
This adds a new
DepoFluxWriter
and deprecates the previous*SimChannelSink
components which are left as-is for now.The new component will correctly write both
trackID
and the new surpriseorigTrackID
to IDEs when it is used in a job that includes a colludingSimDepoSetSource
.The new component provides simpler, less error prone configuration with more correct handling of the response plane location.
The
docs/depofluxwriter.org
text file gives details about this new component and includes a guide for migrating from the now deprecated configuration.Finally, a test is provided that runs g4, WCT sim, sigproc and the new
DepoFluxWriter
to make some plots that visualize the various correct waveform alignments in time that are produced.