Open ebelchio12 opened 1 year ago
The code-checks are being triggered in jenkins.
-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules
has been setup and execute the following command from the top-level directory of your repository:
format-code \
larwirecell/Components/CookedFrameSource.cxx
Then commit the changes and push them to your PR branch.
@ebelchio12 Please apply the clang format as mentioned here: https://github.com/LArSoft/larwirecell/pull/36#issuecomment-1700937799
Hi @ebelchio12
Notes from our meeting
imaging
configuration and instead simply don't apply the new CMM making if the user supplies none of the other new configuration that describes how the CMM is to be built.grep
and awk
to get at the log lines that you are already checking manually and doing a diff
. If the diff
fails, then the test fails.Pull request #36 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.
The code-checks are being triggered in jenkins.
+code-checks
@ebelchio12, is there any update on this?
A new Pull Request was created by @ebelchio12 (Ewerton Belchior) for develop.
It involves the following packages:
larwirecell
@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.
cms-bot commands are listed here