LArSoft / larwirecell

This code is part of the Liquid Argon Software (LArSoft) project. It contains simulation and reconstruction algorithms for LAr TPC detectors. If you have a problem, please log a redmine issue: https://cdcvs.fnal.gov/redmine/projects/larsoft/issues/new
0 stars 18 forks source link

Read in art products for wire-cell imaging #36

Open ebelchio12 opened 1 year ago

FNALbuild commented 1 year ago

A new Pull Request was created by @ebelchio12 (Ewerton Belchior) for develop.

It involves the following packages:

larwirecell

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

FNALbuild commented 1 year ago

The code-checks are being triggered in jenkins.

FNALbuild commented 1 year ago

-code-checks Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larwirecell/Components/CookedFrameSource.cxx

Then commit the changes and push them to your PR branch.

lgarren commented 1 year ago

@ebelchio12 Please apply the clang format as mentioned here: https://github.com/LArSoft/larwirecell/pull/36#issuecomment-1700937799

brettviren commented 1 year ago

Hi @ebelchio12

Notes from our meeting

FNALbuild commented 1 year ago

Pull request #36 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

FNALbuild commented 1 year ago

The code-checks are being triggered in jenkins.

FNALbuild commented 1 year ago

+code-checks

knoepfel commented 1 year ago

@ebelchio12, is there any update on this?