search

LArSoft / larwirecell

This code is part of the Liquid Argon Software (LArSoft) project. It contains simulation and reconstruction algorithms for LAr TPC detectors. If you have a problem, please log a redmine issue: https://cdcvs.fnal.gov/redmine/projects/larsoft/issues/new
0 stars 18 forks source link

Spack build of larwirecell build fails at link time because jsoncpp_lib does not exists. #46

Closed gartung closed 3 months ago

gartung commented 3 months ago

jsoncpp_lib is a target not defined somehow.

FNALbuild commented 3 months ago

A new Pull Request was created by @gartung (Patrick Gartung) for develop.

It involves the following packages:

larwirecell

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

FNALbuild commented 3 months ago

The code-checks are being triggered in jenkins.

FNALbuild commented 3 months ago

+code-checks

FNALbuild commented 3 months ago

Pull request #46 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

FNALbuild commented 3 months ago

The code-checks are being triggered in jenkins.

FNALbuild commented 3 months ago

+code-checks

knoepfel commented 3 months ago

trigger build

FNALbuild commented 3 months ago

The tests are being triggered in jenkins.

FNALbuild commented 3 months ago

-LArSoft tests failed on slf7 for c14:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/22914&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild commented 3 months ago

-LArSoft tests failed on slf7 for e26:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/22913&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

gartung commented 3 months ago

@knoepfel build fails because it can't find json/json.h. Removing jsoncpp_lib and/or jsonnet_lib (targets?) seemed to cause this.

lgarren commented 3 months ago

@gartung I would like some clarification here. If an expected jsoncpp library is not available, shouldn't we be fixing the spack jsoncpp build?

lgarren commented 3 months ago

I'm trying to take a look at this. jsoncpp_lib is a target in the jsoncpp cmake configuration files. The target corresponds to a RelWithDebug build. How is the spack jsoncpp built? What targets are generated?

gartung commented 3 months ago

There is a patch function in the spack recipe for larwirecell. @knoepfel asked me to make a pull request for the same change made in the spack recipe. It apparently does not work with the legacy build system.

gartung commented 3 months ago

The Spack jsoncpp recipe builds with meson for version >= 1.9.2 so the cmake files are not generated. The meson build only install a pkgconfig file. build_system("cmake", conditional("meson", when="@1.9.2:"), default="cmake")

gartung commented 3 months ago

I removed the conditional use of meson on the v0.21.0-fermi branch. I made the same change on v0.22.0-fermi branch so the cmake files should be generated on the next jsoncpp build. I will adjust the larwirecell recipe to remove the patch.