search

LArbys / LArCV

Liquid Argon Computer Vision
11 stars 9 forks source link

ADC threshold values in the viewer #28

Closed drinkingkazu closed 8 years ago

drinkingkazu commented 8 years ago

The "default" ADC thresholds in the viewer might be better fetched from actual min/max ADC value from pixels in the image.

Then whether updating it or not per event should be probably an option to pick for a user (so a user can "freeze" the threshold going one event to the next).

vgenty commented 8 years ago

preliminary implementation in place here i can push to master whenever we are ready https://github.com/LArbys/LArCV/commit/63e5eb5b18bf73ada0fabab0b15e35d9404e7f51

will make it default to the min/max ADC, currently default is to the user. Will change

update: https://github.com/LArbys/LArCV/commit/d98464cc7bcd598397ef3bf6cdba28277537a8cf