search

LArbys / LArCV

Liquid Argon Computer Vision
11 stars 9 forks source link

Probably remove the unneeded random draw in APICaffe::ThreadFillerBase #37

Closed twongjirad closed 8 years ago

twongjirad commented 8 years ago

Wouldn't consider it super urgent, though.

twongjirad commented 8 years ago

Or entry in process_entry( entry) should mean tree index. There is probably a reason why the different indexing is needed, though, that I fail to see.

drinkingkazu commented 8 years ago

I actually remembered why this feature exists: it is because "RandomAccess" configuration parameter is shared among ThreadDatumFiller and underlying IOManager (actually ProcessDriver, which owns IOManager). I'll change it such that ThreadDatumFiller creates its own IO configuration deterministically and never use RandomAccess (ThreadDatumFiller will decide randomness). This way index ThreadDatumFiller thinks = actual index in TTree.

drinkingkazu commented 8 years ago

Addressed: https://github.com/LArbys/LArCV/commit/29ea5ed78475c6656c9f68410962cb10d1ecb6aa

Closing this issue.