search

LArbys / LArCV

Liquid Argon Computer Vision
11 stars 9 forks source link

Rse viewer #63

Open erezcoh4 opened 7 years ago

erezcoh4 commented 7 years ago

refined R/S/E navigation and synced ROI with RGB images

drinkingkazu commented 7 years ago

Should we evaluate this branch? Help resolving conflicts etc.? @erezcoh4 feel free to tag others as participants. I tag myself. If you can specify some specific things (like I asked above) then I'm happy to help.

vgenty commented 7 years ago

Yes we should evaluate, I think i see some binary files committed to this branch such as w/ this commit https://github.com/LArbys/LArCV/pull/63/commits/417ea31505b9ec7c63f7d3277d8ff27f6806106d. In addition there are some hard coded paths we need to address present in this commit https://github.com/LArbys/LArCV/pull/63/commits/8add435e79f2813a1536b02fecc05002fbcfe678

erezcoh4 commented 7 years ago

thanks @vgenty and @drinkingkazu the hard-coded paths make it easier for me to load the (same) ROI file i use every time. I plan (when i have time....) to add a loading widget that will prevent the user from having to type the full path every time he wants to load the ROI file, and change the production widget to a pop-up list. does this make sense?

twongjirad commented 7 years ago

though I understand the hardcoded paths are useful to you, develop is for everyone. and everyone uses the ROI tools for hand-scanning. in order to merge into develop, those need to be removed.

erezcoh4 commented 7 years ago

hhh, i didn't mean that we should keep these paths of course... just meant to explain myself; i'll remove them of course... sorry

twongjirad commented 7 years ago

Oh, sorry! I misunderstood. Thanks!