search

LArbys / LArCV

Liquid Argon Computer Vision
11 stars 9 forks source link

develop branch missing DataFormat/ParticleMass.h #82

Closed twongjirad closed 7 years ago

twongjirad commented 7 years ago

app/Filter/CCQETruthFilter.cxx requires it. Stopping the build from finishing.

drinkingkazu commented 7 years ago

done @ c7d037c3e213b318fd83745ae45c0f5121dbbc80

drinkingkazu commented 7 years ago

But I do get a compiler error that looks like a compiler version issue while building DBSCANN algorithm:

In file included from DBSCANAlgo.cxx:3: In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/algorithm:62: /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_algo.h:2263:11: error: no matching function for call to object of type 'mycompare_t' while (comp(*first, pivot)) ^~ /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_algo.h:2296:19: note: in instantiation of function template specialization 'std::unguarded_partition<gnu_cxx::normal_iterator<std::pair<int, double> *, std::vector<std::pair<int, double>, std::allocator<std::pair<int, double> > > >, std::pair<int, double>, mycompare_t>' requested here return std::unguarded_partition(first + 1, last, *first, comp); ^ /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_algo.h:2337:11: note: in instantiation of function template specialization 'std::unguarded_partition_pivot<gnu_cxx::normal_iterator<std::pair<int, double> *, std::vector<std::pair<int, double>, std::allocator<std::pair<int, double> > > >, mycompare_t>' requested here std::unguarded_partition_pivot(first, last, comp); ^ /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_algo.h:5498:9: note: in instantiation of function template specialization 'std::introsort_loop<gnu_cxx::normal_iterator<std::pair<int, double> *, std::vector<std::pair<int, double>, std::allocator<std::pair<int, double> > > >, long, mycompare_t>' requested here std::introsort_loop(first, last, ^ DBSCANAlgo.cxx:264:12: note: in instantiation of function template specialization 'std::sort<__gnu_cxx::__normal_iterator<std::pair<int, double> *, std::vector<std::pair<int, double>, std::allocator<std::pair<int, double> > > >, mycompare_t>' requested here std::sort( hitlist.begin(), hitlist.end(), mycompare ); ^ DBSCANAlgo.cxx:221:12: note: candidate function not viable: 2nd argument ('const std::pair<int, double>') would lose const qualifier bool operator() ( std::pair<int,double>& lhs, std::pair<int,double>& rhs ) { ^ In file included from DBSCANAlgo.cxx:3: In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/algorithm:62:

vgenty commented 7 years ago

Same result as above on develop with GCC 4.8.4 on ubuntu 14.04.5

https://goo.gl/Uj8ZCE

twongjirad commented 7 years ago

thanks guys! moving this new issue into its own record #84