LBALab / lba2remake

A Little Big Adventure 2 / Twinsen's Odyssey reimplementation in JavaScript / Three.js / React
MIT License
253 stars 38 forks source link

Can't properly see the "Replace by 3D model" button on the Iso Layouts Editor #316

Open felipesanches opened 4 years ago

felipesanches commented 4 years ago

The button does not fit the UI. We can barely see a tiny bit of its top portion, but none of the text label as it overflows the available window area.

I tried resizing the browser window, but still can't make it fit. I also tried entering full-screen also to no avail.

The only way to see a slightly larger portion of the button is by tweaking the browser zoom level, but that completely messes up the rest of the UI.

Screenshot from 2020-07-10 21-24-39

felipesanches commented 4 years ago

Screenshot from 2020-07-10 21-39-15

xesf commented 4 years ago

You should be able to resize the area with the mouse. The size will be persisted next time you open the same Editor Tool

felipesanches commented 4 years ago

I just tried it, but it also does not work. When resizing, the button still does not fit the available area:

Screenshot from 2020-07-11 12-39-25

agrande commented 4 years ago

Hmm, weird, it looks much bigger than in Chrome... I guess there's no specific styling on those buttons and it's using the browser defaults. I'll take a look at it.

agrande commented 4 years ago

Can you check if the changes I made fixed the issue for you? https://autopush.lba2remake.net/

felipesanches commented 4 years ago

It got just a bit better, but still not fitting.

Screenshot from 2020-07-11 14-03-14

I looked at your commit and tweaked the values. Making this change, it now looks good:

const infoButton = {
    margin: '1px',
    padding: '0em'
};

Screenshot from 2020-07-11 14-00-59

agrande commented 4 years ago

As mentioned in the PR, the padding that you see on those buttons isn't specified in code (html/css), so it's your browser taking liberties here. I couldn't reproduce the issue in any major browser. The solution probably involves understanding what could cause your browser to not respect the web standards (custom config? exotic linux distro? ...).

felipesanches commented 4 years ago

I haven't investigated this any further. There's nothing "exotic" in my distro. It is just Debian 10. I won't be able to look into this now, but I may do so later. Please leave this open as someone else may be facing similar issue or may know of a good solution.

agrande commented 4 years ago

Yes, I’m leaving this open, I only closed the PR.