LBCrion / sfwbar

S* Floating Window Bar
GNU General Public License v3.0
264 stars 16 forks source link

No tooltip in tray items #222

Closed 01micko closed 2 days ago

01micko commented 2 weeks ago

I'm on my debian system running beta15.

I've never used the tray feature but since nm-applet is installed I'd thought I'd give it a try, and works well and stylized to match my other widgets. I don't get a tooltip however, and nm-applet does have one in X11. Don't know if it's fixed in latest (running it on my laptop) because I don't use anything that runs a tray applet. If it is, sorry for the noise.

LBCrion commented 2 weeks ago

This isn't noise. This is a bug. It looks like tooltips got lost when I split sni backend from the gui. I'll add them back when I'm back next week.

On Mon, 26 Aug 2024, 10:02 micko, @.***> wrote:

I'm on my debian system running beta15.

I've never used the tray feature but since nm-applet is installed I'd thought I'd give it a try, and works well and stylized to match my other widgets. I don't get a tooltip however, and nm-applet does have one in X11. Don't know if it's fixed in latest (running it on my laptop) because I don't use anything that runs a tray applet. If it is, sorry for the noise.

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/222, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFAPICDL3H5LRN2L66TZTLHHTAVCNFSM6AAAAABNDMRRN6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4DMMBZGY2TCMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

01micko commented 2 weeks ago

@WSA1k this looks like spam.. wouldn't be the first time.

@LBCrion thanks! No rush as usual :)

LBCrion commented 1 week ago

Should be done. Can you check if the latest git shows a tooltip as expected please? (nm applet doesn't send a tooltip on my system as I don't have networkmanager running).

On Mon, Aug 26, 2024 at 8:18 AM micko @.***> wrote:

@WSA1k https://github.com/WSA1k this looks like spam.. wouldn't be the first time.

@LBCrion https://github.com/LBCrion thanks! No rush as usual :)

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/222#issuecomment-2309509883, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFGM2MPY6SPY3XP2OPLZTLJEDAVCNFSM6AAAAABNDMRRN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZGUYDSOBYGM . You are receiving this because you were mentioned.Message ID: @.***>

01micko commented 1 week ago

Just tried and seems it isn't fixed.

Anything I can do to debug?

LBCrion commented 1 week ago

Can you try running sfwbar in a terminal with arguments "-d -g sni" to see what's coming through on dbus?

On Mon, Sep 2, 2024 at 11:51 AM micko @.***> wrote:

Just tried and seems it isn't fixed.

Anything I can do to debug?

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/222#issuecomment-2324428432, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFDJIVNP2VYWIU5PWYDZUQ7LPAVCNFSM6AAAAABNDMRRN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUGQZDQNBTGI . You are receiving this because you were mentioned.Message ID: @.***>

01micko commented 1 week ago
20:59:18.21 sni watcher org.kde.StatusNotifierWatcher registered
20:59:18.21 sni watcher org.freedesktop.StatusNotifierWatcher registered
20:59:18.23 sni host org.kde.StatusNotifierHost-11137: found watcher org.kde.StatusNotifierWatcher (:1.63)
20:59:18.23 sni host org.freedesktop.StatusNotifierHost-11137: found watcher org.freedesktop.StatusNotifierWatcher (:1.63)
20:59:18.23 sni watcher org.kde.StatusNotifierWatcher: watching item :1.18
20:59:18.23 sni watcher org.kde.StatusNotifierWatcher: registered host org.kde.StatusNotifierHost-11137
20:59:18.24 sni watcher org.freedesktop.StatusNotifierWatcher: registered host org.freedesktop.StatusNotifierHost-11137
20:59:18.25 sni host org.kde.StatusNotifierHost-11137: item registered: :1.18 /org/ayatana/NotificationItem/nm_applet
20:59:18.25 sni :1.18: property Category = SystemServices
20:59:18.25 sni :1.18: property Id = nm-applet
20:59:18.25 sni :1.18: property Title = Network
20:59:18.25 sni :1.18: property Status = Active
20:59:18.25 sni :1.18: property IconName = nm-signal-75
20:59:18.29 sni :1.18: property AttentionIconName = 
20:59:18.29 sni :1.18: property XAyatanaLabel = 
20:59:18.29 sni :1.18: property XAyatanaLabelGuide = 
20:59:18.29 sni :1.18: property IconThemePath = 
20:59:18.29 sni :1.18: property Menu = /org/ayatana/NotificationItem/nm_applet/Menu
20:59:18.29 sni :1.18: property XAyatanaOrderingIndex = 0
LBCrion commented 1 week ago

Egads, I just realized I've never implemented handling of a tooltip property. I added a basic implementation and it seems to work with blueman-applet. Can you check if it works for you when you get a chance please? (latest git version)

On Mon, Sep 2, 2024 at 12:02 PM micko @.***> wrote:

20:59:18.21 sni watcher org.kde.StatusNotifierWatcher registered 20:59:18.21 sni watcher org.freedesktop.StatusNotifierWatcher registered 20:59:18.23 sni host org.kde.StatusNotifierHost-11137: found watcher org.kde.StatusNotifierWatcher (:1.63) 20:59:18.23 sni host org.freedesktop.StatusNotifierHost-11137: found watcher org.freedesktop.StatusNotifierWatcher (:1.63) 20:59:18.23 sni watcher org.kde.StatusNotifierWatcher: watching item :1.18 20:59:18.23 sni watcher org.kde.StatusNotifierWatcher: registered host org.kde.StatusNotifierHost-11137 20:59:18.24 sni watcher org.freedesktop.StatusNotifierWatcher: registered host org.freedesktop.StatusNotifierHost-11137 20:59:18.25 sni host org.kde.StatusNotifierHost-11137: item registered: :1.18 /org/ayatana/NotificationItem/nm_applet 20:59:18.25 sni :1.18: property Category = SystemServices 20:59:18.25 sni :1.18: property Id = nm-applet 20:59:18.25 sni :1.18: property Title = Network 20:59:18.25 sni :1.18: property Status = Active 20:59:18.25 sni :1.18: property IconName = nm-signal-75 20:59:18.29 sni :1.18: property AttentionIconName = 20:59:18.29 sni :1.18: property XAyatanaLabel = 20:59:18.29 sni :1.18: property XAyatanaLabelGuide = 20:59:18.29 sni :1.18: property IconThemePath = 20:59:18.29 sni :1.18: property Menu = /org/ayatana/NotificationItem/nm_applet/Menu 20:59:18.29 sni :1.18: property XAyatanaOrderingIndex = 0

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/222#issuecomment-2324450034, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFCTHGUASZKPTNH2QLLZURAUZAVCNFSM6AAAAABNDMRRN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUGQ2TAMBTGQ . You are receiving this because you were mentioned.Message ID: @.***>

01micko commented 1 week ago

Seems still failing.

mick@dellhome:~$ sfwbar -d -g sni
15:41:18.45 sni watcher org.kde.StatusNotifierWatcher registered
15:41:18.45 sni watcher org.freedesktop.StatusNotifierWatcher registered
15:41:18.47 sni host org.kde.StatusNotifierHost-4473: found watcher org.kde.StatusNotifierWatcher (:1.84)
15:41:18.47 sni host org.freedesktop.StatusNotifierHost-4473: found watcher org.freedesktop.StatusNotifierWatcher (:1.84)
15:41:18.47 sni watcher org.kde.StatusNotifierWatcher: watching item :1.19
15:41:18.47 sni watcher org.kde.StatusNotifierWatcher: registered host org.kde.StatusNotifierHost-4473
15:41:18.47 sni watcher org.freedesktop.StatusNotifierWatcher: registered host org.freedesktop.StatusNotifierHost-4473
15:41:18.47 sni host org.kde.StatusNotifierHost-4473: item registered: :1.19 /org/ayatana/NotificationItem/nm_applet
15:41:18.48 sni :1.19: property Category = SystemServices
15:41:18.48 sni :1.19: property Id = nm-applet
15:41:18.48 sni :1.19: property Title = Network
15:41:18.48 sni :1.19: property Status = Active
15:41:18.48 sni :1.19: property IconName = nm-signal-75
15:41:18.48 sni :1.19: property AttentionIconName = 
15:41:18.48 sni :1.19: property XAyatanaLabel = 
15:41:18.48 sni :1.19: property XAyatanaLabelGuide = 
15:41:18.48 sni :1.19: property IconThemePath = 
15:41:18.48 sni :1.19: property Menu = /org/ayatana/NotificationItem/nm_applet/Menu
15:41:18.48 sni :1.19: property XAyatanaOrderingIndex = 0

looks like I have to update my CSS too

beta 15 20240903_15h40m04s_grim

current git 20240903_15h41m32s_grim

LBCrion commented 1 week ago

What does your tray CSS look like? I updated tray styling, but it should handle old CSS as is for now.

On Tue, Sep 3, 2024 at 6:47 AM micko @.***> wrote:

Seems still failing.

@.***:~$ sfwbar -d -g sni 15:41:18.45 sni watcher org.kde.StatusNotifierWatcher registered 15:41:18.45 sni watcher org.freedesktop.StatusNotifierWatcher registered 15:41:18.47 sni host org.kde.StatusNotifierHost-4473: found watcher org.kde.StatusNotifierWatcher (:1.84) 15:41:18.47 sni host org.freedesktop.StatusNotifierHost-4473: found watcher org.freedesktop.StatusNotifierWatcher (:1.84) 15:41:18.47 sni watcher org.kde.StatusNotifierWatcher: watching item :1.19 15:41:18.47 sni watcher org.kde.StatusNotifierWatcher: registered host org.kde.StatusNotifierHost-4473 15:41:18.47 sni watcher org.freedesktop.StatusNotifierWatcher: registered host org.freedesktop.StatusNotifierHost-4473 15:41:18.47 sni host org.kde.StatusNotifierHost-4473: item registered: :1.19 /org/ayatana/NotificationItem/nm_applet 15:41:18.48 sni :1.19: property Category = SystemServices 15:41:18.48 sni :1.19: property Id = nm-applet 15:41:18.48 sni :1.19: property Title = Network 15:41:18.48 sni :1.19: property Status = Active 15:41:18.48 sni :1.19: property IconName = nm-signal-75 15:41:18.48 sni :1.19: property AttentionIconName = 15:41:18.48 sni :1.19: property XAyatanaLabel = 15:41:18.48 sni :1.19: property XAyatanaLabelGuide = 15:41:18.48 sni :1.19: property IconThemePath = 15:41:18.48 sni :1.19: property Menu = /org/ayatana/NotificationItem/nm_applet/Menu 15:41:18.48 sni :1.19: property XAyatanaOrderingIndex = 0

looks like I have to update my CSS too

beta 5 20240903_15h40m04s_grim.png (view on web) https://github.com/user-attachments/assets/237e027b-dc94-407d-8d06-5a3f50ab9fcb

current git 20240903_15h41m32s_grim.png (view on web) https://github.com/user-attachments/assets/25a3b20a-919d-4e37-8f30-97f97a013023

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/222#issuecomment-2325650846, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFGSIZYPNJQ5ETZERATZUVENVAVCNFSM6AAAAABNDMRRN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGY2TAOBUGY . You are receiving this because you were mentioned.Message ID: @.***>

01micko commented 1 week ago

Here is the tray CSS

button#tray_active,
button#tray_passive,
button#tray_attention {
  background-image: none;
  border: 0px;
  padding: 0px;
  margin: 0px;
  border-image: none;
  border-radius: 0px;
  outline-style: none;
  box-shadow: none;
  -GtkWidget-direction: bottom;
  padding: 2px;
}

button#tray_active image,
button#tray_passive image,
button#tray_attention image {
  min-width: 18px;
  min-height: 18px;
  padding: 2px;
  -ScaleImage-color: @theme_fg_color;
}
LBCrion commented 1 week ago

This would be because I missed a file in the commit (config parser). This should hopefully be fixed now. For the tooltip. I setup NetworkManager and tried nm-applet. It doesn't send a tooltip on my system. Can you check if it actually exposes tooltip data in its properties? I.e. try running sfwbar -d -g sni, check what destination and path nm-applet uses and try introspecting it (gdbus introspect -e -d :1.18722 -o /org/ayatana/NotificationItem/nm_applet) if you have gdbus. You'll need to destination interface from sfwbar output instead of :1.18722.

On Tue, Sep 3, 2024 at 7:43 AM micko @.***> wrote:

Here is the tray CSS

button#tray_active,button#tray_passive,button#tray_attention { background-image: none; border: 0px; padding: 0px; margin: 0px; border-image: none; border-radius: 0px; outline-style: none; box-shadow: none; -GtkWidget-direction: bottom; padding: 2px; } button#tray_active image,button#tray_passive image,button#tray_attention image { min-width: 18px; min-height: 18px; padding: 2px; -ScaleImage-color: @theme_fg_color; }

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/222#issuecomment-2325720367, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFEI774G7BSOXAXCZ63ZUVLADAVCNFSM6AAAAABNDMRRN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVG4ZDAMZWG4 . You are receiving this because you were mentioned.Message ID: @.***>

01micko commented 1 week ago

Ok

mick@dellhome:~$ gdbus introspect -e -d :1.19 -o /org/ayatana/NotificationItem/nm_applet
node /org/ayatana/NotificationItem/nm_applet {
  interface org.freedesktop.DBus.Properties {
    methods:
      Get(in  s interface_name,
          in  s property_name,
          out v value);
      GetAll(in  s interface_name,
             out a{sv} properties);
      Set(in  s interface_name,
          in  s property_name,
          in  v value);
    signals:
      PropertiesChanged(s interface_name,
                        a{sv} changed_properties,
                        as invalidated_properties);
    properties:
  };
  interface org.freedesktop.DBus.Introspectable {
    methods:
      Introspect(out s xml_data);
    signals:
    properties:
  };
  interface org.freedesktop.DBus.Peer {
    methods:
      Ping();
      GetMachineId(out s machine_uuid);
    signals:
    properties:
  };
  interface org.kde.StatusNotifierItem {
    methods:
      Scroll(in  i delta,
             in  s orientation);
      SecondaryActivate(in  i x,
                        in  i y);
      XAyatanaSecondaryActivate(in  u timestamp);
    signals:
      NewIcon();
      NewIconThemePath(s icon_theme_path);
      NewAttentionIcon();
      NewStatus(s status);
      XAyatanaNewLabel(s label,
                       s guide);
      NewTitle();
    properties:
      readonly s Id = 'nm-applet';
      readonly s Category = 'SystemServices';
      readonly s Status = 'Active';
      readonly s IconName = 'nm-signal-75';
      readonly s IconAccessibleDesc = 'Wi-Fi network connection “keep_out” active: keep_out (54%)';
      readonly s AttentionIconName = '';
      readonly s AttentionAccessibleDesc = '';
      readonly s Title = 'Network';
      readonly s IconThemePath = '';
      readonly o Menu = '/org/ayatana/NotificationItem/nm_applet/Menu';
      readonly s XAyatanaLabel = '';
      readonly s XAyatanaLabelGuide = '';
      readonly u XAyatanaOrderingIndex = 0;
  };
  node Menu {
  };
};

If memory serves, the tooltip in X was 'Wi-Fi network connection “keep_out” active: keep_out (54%)'

Oh, thanks for the quick CSS fix :)

LBCrion commented 1 week ago

Looking at the output there is no tooltip information provided. Here's what I see for blueman for example. property Tooltip is populated: ... interface org.kde.StatusNotifierItem { methods: Activate(in i arg_0, in i arg_1); signals: NewIcon(); NewStatus(s arg_0); NewToolTip(); properties: readonly s Category = 'Hardware'; readonly s Id = 'blueman'; readonly s IconName = 'blueman-tray'; readonly s Status = 'Active'; readonly s Title = 'blueman'; readonly (sa(iiay)ss) ToolTip = ('', [], 'Bluetooth Enabled', ''); readonly o Menu = '/org/blueman/sni/menu'; readonly b ItemIsMenu = false; }; node menu { }; };

On Tue, Sep 3, 2024 at 8:14 AM micko @.***> wrote:

Ok

@.***:~$ gdbus introspect -e -d :1.19 -o /org/ayatana/NotificationItem/nm_applet node /org/ayatana/NotificationItem/nm_applet { interface org.freedesktop.DBus.Properties { methods: Get(in s interface_name, in s property_name, out v value); GetAll(in s interface_name, out a{sv} properties); Set(in s interface_name, in s property_name, in v value); signals: PropertiesChanged(s interface_name, a{sv} changed_properties, as invalidated_properties); properties: }; interface org.freedesktop.DBus.Introspectable { methods: Introspect(out s xml_data); signals: properties: }; interface org.freedesktop.DBus.Peer { methods: Ping(); GetMachineId(out s machine_uuid); signals: properties: }; interface org.kde.StatusNotifierItem { methods: Scroll(in i delta, in s orientation); SecondaryActivate(in i x, in i y); XAyatanaSecondaryActivate(in u timestamp); signals: NewIcon(); NewIconThemePath(s icon_theme_path); NewAttentionIcon(); NewStatus(s status); XAyatanaNewLabel(s label, s guide); NewTitle(); properties: readonly s Id = 'nm-applet'; readonly s Category = 'SystemServices'; readonly s Status = 'Active'; readonly s IconName = 'nm-signal-75'; readonly s IconAccessibleDesc = 'Wi-Fi network connection “keep_out” active: keep_out (54%)'; readonly s AttentionIconName = ''; readonly s AttentionAccessibleDesc = ''; readonly s Title = 'Network'; readonly s IconThemePath = ''; readonly o Menu = '/org/ayatana/NotificationItem/nm_applet/Menu'; readonly s XAyatanaLabel = ''; readonly s XAyatanaLabelGuide = ''; readonly u XAyatanaOrderingIndex = 0; }; node Menu { }; };

If memory serves, the tooltip in X was 'Wi-Fi network connection “keep_out” active: keep_out (54%)'

Oh, thanks for the quick CSS fix :)

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/222#issuecomment-2325768827, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFAIAP35D574BVI3CO3ZUVOVDAVCNFSM6AAAAABNDMRRN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVG43DQOBSG4 . You are receiving this because you were mentioned.Message ID: @.***>

LBCrion commented 1 week ago

Actually, looking at your description above, it looks like IconAccessibleDescription is used for tooltip.

On Tue, Sep 3, 2024 at 8:20 AM Lev Babiev @.***> wrote:

Looking at the output there is no tooltip information provided. Here's what I see for blueman for example. property Tooltip is populated: ... interface org.kde.StatusNotifierItem { methods: Activate(in i arg_0, in i arg_1); signals: NewIcon(); NewStatus(s arg_0); NewToolTip(); properties: readonly s Category = 'Hardware'; readonly s Id = 'blueman'; readonly s IconName = 'blueman-tray'; readonly s Status = 'Active'; readonly s Title = 'blueman'; readonly (sa(iiay)ss) ToolTip = ('', [], 'Bluetooth Enabled', ''); readonly o Menu = '/org/blueman/sni/menu'; readonly b ItemIsMenu = false; }; node menu { }; };

On Tue, Sep 3, 2024 at 8:14 AM micko @.***> wrote:

Ok

@.***:~$ gdbus introspect -e -d :1.19 -o /org/ayatana/NotificationItem/nm_applet node /org/ayatana/NotificationItem/nm_applet { interface org.freedesktop.DBus.Properties { methods: Get(in s interface_name, in s property_name, out v value); GetAll(in s interface_name, out a{sv} properties); Set(in s interface_name, in s property_name, in v value); signals: PropertiesChanged(s interface_name, a{sv} changed_properties, as invalidated_properties); properties: }; interface org.freedesktop.DBus.Introspectable { methods: Introspect(out s xml_data); signals: properties: }; interface org.freedesktop.DBus.Peer { methods: Ping(); GetMachineId(out s machine_uuid); signals: properties: }; interface org.kde.StatusNotifierItem { methods: Scroll(in i delta, in s orientation); SecondaryActivate(in i x, in i y); XAyatanaSecondaryActivate(in u timestamp); signals: NewIcon(); NewIconThemePath(s icon_theme_path); NewAttentionIcon(); NewStatus(s status); XAyatanaNewLabel(s label, s guide); NewTitle(); properties: readonly s Id = 'nm-applet'; readonly s Category = 'SystemServices'; readonly s Status = 'Active'; readonly s IconName = 'nm-signal-75'; readonly s IconAccessibleDesc = 'Wi-Fi network connection “keep_out” active: keep_out (54%)'; readonly s AttentionIconName = ''; readonly s AttentionAccessibleDesc = ''; readonly s Title = 'Network'; readonly s IconThemePath = ''; readonly o Menu = '/org/ayatana/NotificationItem/nm_applet/Menu'; readonly s XAyatanaLabel = ''; readonly s XAyatanaLabelGuide = ''; readonly u XAyatanaOrderingIndex = 0; }; node Menu { }; };

If memory serves, the tooltip in X was 'Wi-Fi network connection “keep_out” active: keep_out (54%)'

Oh, thanks for the quick CSS fix :)

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/222#issuecomment-2325768827, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFAIAP35D574BVI3CO3ZUVOVDAVCNFSM6AAAAABNDMRRN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVG43DQOBSG4 . You are receiving this because you were mentioned.Message ID: @.***>

01micko commented 1 week ago

My thoughts exactly :)

01micko commented 1 week ago

screngrab from xfce

bingo

LBCrion commented 1 week ago

Right. This looks to be yet another example specification as written (StatusNotifierItem spec) vs specification as everyone uses it (libappindicator). XFCE seems to have gone through the same malarkey: https://bugzilla.xfce.org/show_bug.cgi?id=12417 I've added support for IconAccessibleDesc / AttnAccessibleDesc and logic to use Tooltip when available and fallback to AccessibleDesc's if not. This should cover all scenarios.

On Tue, Sep 3, 2024 at 8:28 AM micko @.***> wrote:

screngrab from xfce

bingo.png (view on web) https://github.com/user-attachments/assets/217ecc53-0f8a-43b1-a4c6-fbf043d7a0f2

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/222#issuecomment-2325792729, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFDNJPAFUDXEJCCZEBTZUVQKNAVCNFSM6AAAAABNDMRRN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVG44TENZSHE . You are receiving this because you were mentioned.Message ID: @.***>

01micko commented 1 week ago

XDG StatusNotifierItem supports ToolTip field. But libappindicator doesn't. It supports IconAccessibleDesc instead as a part of indicator icon

Great standards we have! I'll try it now.

01micko commented 1 week ago

works

Thanks very much for pursuing this! Works like a charm and I have little doubt that it would after we discovered IconAccessibleDesc :)

Closing.

01micko commented 2 days ago

Since 02049b6 where I reported in #230 that it's working tooltips, disappeared for nm-applet

Indeed IconAccessibleDesc = ''

mick@dellhome:~$ gdbus introspect -e -d :1.28 -o /org/ayatana/NotificationItem/nm_applet
node /org/ayatana/NotificationItem/nm_applet {
  interface org.freedesktop.DBus.Properties {
    methods:
      Get(in  s interface_name,
          in  s property_name,
          out v value);
      GetAll(in  s interface_name,
             out a{sv} properties);
      Set(in  s interface_name,
          in  s property_name,
          in  v value);
    signals:
      PropertiesChanged(s interface_name,
                        a{sv} changed_properties,
                        as invalidated_properties);
    properties:
  };
  interface org.freedesktop.DBus.Introspectable {
    methods:
      Introspect(out s xml_data);
    signals:
    properties:
  };
  interface org.freedesktop.DBus.Peer {
    methods:
      Ping();
      GetMachineId(out s machine_uuid);
    signals:
    properties:
  };
  interface org.kde.StatusNotifierItem {
    methods:
      Scroll(in  i delta,
             in  s orientation);
      SecondaryActivate(in  i x,
                        in  i y);
      XAyatanaSecondaryActivate(in  u timestamp);
    signals:
      NewIcon();
      NewIconThemePath(s icon_theme_path);
      NewAttentionIcon();
      NewStatus(s status);
      XAyatanaNewLabel(s label,
                       s guide);
      NewTitle();
    properties:
      readonly s Id = 'nm-applet';
      readonly s Category = 'SystemServices';
      readonly s Status = 'Active';
      readonly s IconName = 'nm-signal-75';
      readonly s IconAccessibleDesc = '';
      readonly s AttentionIconName = '';
      readonly s AttentionAccessibleDesc = '';
      readonly s Title = 'Network';
      readonly s IconThemePath = '';
      readonly o Menu = '/org/ayatana/NotificationItem/nm_applet/Menu';
      readonly s XAyatanaLabel = '';
      readonly s XAyatanaLabelGuide = '';
      readonly u XAyatanaOrderingIndex = 0;
  };
  node Menu {
  };
};

I'm sure it would be just a simple omission.

I checked in X11 and the tooltip is still there.

01micko commented 2 days ago

Weird, after logging back into labwc it appears resolved. Maybe an nm-applet quirk. This one is noise! Apologies!

mick@dellhome:~$ gdbus introspect -e -d :1.28 -o /org/ayatana/NotificationItem/nm_applet
node /org/ayatana/NotificationItem/nm_applet {
  interface org.freedesktop.DBus.Properties {
    methods:
      Get(in  s interface_name,
          in  s property_name,
          out v value);
      GetAll(in  s interface_name,
             out a{sv} properties);
      Set(in  s interface_name,
          in  s property_name,
          in  v value);
    signals:
      PropertiesChanged(s interface_name,
                        a{sv} changed_properties,
                        as invalidated_properties);
    properties:
  };
  interface org.freedesktop.DBus.Introspectable {
    methods:
      Introspect(out s xml_data);
    signals:
    properties:
  };
  interface org.freedesktop.DBus.Peer {
    methods:
      Ping();
      GetMachineId(out s machine_uuid);
    signals:
    properties:
  };
  interface org.kde.StatusNotifierItem {
    methods:
      Scroll(in  i delta,
             in  s orientation);
      SecondaryActivate(in  i x,
                        in  i y);
      XAyatanaSecondaryActivate(in  u timestamp);
    signals:
      NewIcon();
      NewIconThemePath(s icon_theme_path);
      NewAttentionIcon();
      NewStatus(s status);
      XAyatanaNewLabel(s label,
                       s guide);
      NewTitle();
    properties:
      readonly s Id = 'nm-applet';
      readonly s Category = 'SystemServices';
      readonly s Status = 'Active';
      readonly s IconName = 'nm-signal-100';
      readonly s IconAccessibleDesc = 'Wi-Fi network connection “keep_out” active: keep_out (70%)';
      readonly s AttentionIconName = '';
      readonly s AttentionAccessibleDesc = '';
      readonly s Title = 'Network';
      readonly s IconThemePath = '';
      readonly o Menu = '/org/ayatana/NotificationItem/nm_applet/Menu';
      readonly s XAyatanaLabel = '';
      readonly s XAyatanaLabelGuide = '';
      readonly u XAyatanaOrderingIndex = 0;
  };
  node Menu {
  };
};
LBCrion commented 2 days ago

This looks like something was misbehaving on the nm-applet side. Since it was exporting an empty IconAccesibleDesc, sfwbar had no tooltip to display.

On Thu, Sep 12, 2024 at 8:55 AM micko @.***> wrote:

Weird, after logging back into labwc it appears resolved. Maybe an nm-applet quirk. This one is noise! Apologies!

@.***:~$ gdbus introspect -e -d :1.28 -o /org/ayatana/NotificationItem/nm_applet node /org/ayatana/NotificationItem/nm_applet { interface org.freedesktop.DBus.Properties { methods: Get(in s interface_name, in s property_name, out v value); GetAll(in s interface_name, out a{sv} properties); Set(in s interface_name, in s property_name, in v value); signals: PropertiesChanged(s interface_name, a{sv} changed_properties, as invalidated_properties); properties: }; interface org.freedesktop.DBus.Introspectable { methods: Introspect(out s xml_data); signals: properties: }; interface org.freedesktop.DBus.Peer { methods: Ping(); GetMachineId(out s machine_uuid); signals: properties: }; interface org.kde.StatusNotifierItem { methods: Scroll(in i delta, in s orientation); SecondaryActivate(in i x, in i y); XAyatanaSecondaryActivate(in u timestamp); signals: NewIcon(); NewIconThemePath(s icon_theme_path); NewAttentionIcon(); NewStatus(s status); XAyatanaNewLabel(s label, s guide); NewTitle(); properties: readonly s Id = 'nm-applet'; readonly s Category = 'SystemServices'; readonly s Status = 'Active'; readonly s IconName = 'nm-signal-100'; readonly s IconAccessibleDesc = 'Wi-Fi network connection “keep_out” active: keep_out (70%)'; readonly s AttentionIconName = ''; readonly s AttentionAccessibleDesc = ''; readonly s Title = 'Network'; readonly s IconThemePath = ''; readonly o Menu = '/org/ayatana/NotificationItem/nm_applet/Menu'; readonly s XAyatanaLabel = ''; readonly s XAyatanaLabelGuide = ''; readonly u XAyatanaOrderingIndex = 0; }; node Menu { }; };

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/222#issuecomment-2345526280, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFHSDOY3ZSSHZDUIYMLZWFCHDAVCNFSM6AAAAABNDMRRN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBVGUZDMMRYGA . You are receiving this because you were mentioned.Message ID: @.***>