search

LBCrion / sfwbar

S* Floating Window Bar
GNU General Public License v3.0
274 stars 17 forks source link

FreeBSD Port #64

Open elgithubo opened 1 year ago

elgithubo commented 1 year ago

Since I noticed sfwbar works great in FreeBSD but has not made its way into the ports collection yet, I am thinking about changing this. It has been a loooong time since I made my last port, so it may take some time (and ofc I won't promise anything ;)). Anyhow I am interested in doing this and would be happy if I could drop eventual issues during porting here.

LBCrion commented 1 year ago

That's great! Happy to help as much as I can with this. I looked briefly at FreeBSD ports and it looked fairly straightforward, but without access to a FreeBSD system, I wouldn't have had a chance to test. Do flag any issues you encounter of course.

elgithubo commented 1 year ago

Thank you for your quick response. I have created a port draft for FreeBSD under https://github.com/elgithubo/sfwbar_freebsd_port. It builds fine and should also install, but I will be testing the install process tomorrow or so, it's late here. :smile:

elgithubo commented 1 year ago

FreeBSD port has been accepted: https://www.freshports.org/x11/sfwbar/

LBCrion commented 1 year ago

This is fantastic! Thank you for doing this. Alas, I'm afraid I'll make your life more difficult with the next release. I'm working on loadable modules support which will allow sfwbar to support features with build time and runtime optional dependencies. I'll also likely need help testing some of these features on FreeBSD, since some of the code will need to be OS specific (i.e. wifi status queries).

elgithubo commented 1 year ago

Well I am going to see it as a positive challenge. Fortunately FreeBSD ports support pre-compilation patching of source files, so in the worst case I could potentially remove features that do not work on FreeBSD. Are you talking about modules in the sense of kernel modules or will there be specific sfwbar modules? Anyhow I will be happy to handle the upgrades for the FreeBSD platform with regards to testing and other necessary things as good as possible.

LBCrion commented 1 year ago

Well I am going to see it as a positive challenge.

Good. I have what I believe is a working version of FreeBSD compatible network sfwbar module and would greatly appreciate if you could test it on a FreeBSD system (preferably with a wifi network interface).

To test it you will need the following config file:

module("network")

layout {
  label {
    value = "interface: " + NetInfo("interface")
    trigger = "network"
    loc(1,1)
  }
  label {
    value = "ip: " + NetInfo("ip")
    trigger = "network"
    loc(1,2)
  }
  label {
    value = "netmask: " + NetInfo("mask")
    trigger = "network"
    loc(2,1)
  }
  label {
    value = "gateway: " + NetInfo("gateway")
    trigger = "network"
    loc(2,2)
  }
  label {
    value = "essid: " + NetInfo("essid")
    trigger = "network"
    loc(3,1)
  }
  label {
    value = "signal: " + Str(NetInfo("signal"),0) + "%"
    interval =6000
    loc(3,2)
  }
}

#CSS
label {
padding: 2px;
padding-right: 10px;
-GtkWidget-align: 0.0;
}

The instruction are as following:

  1. Create a new directory
  2. Put the above file into a file network.config in this new directory
  3. run the following commands: 
    git clone https://github.com/LBCrion/sfwbar.git
meson build
ninja -C build
cp build/libnetwork.so .
./build/sfwbar -f ./network.config

    If everything is working correctly, this should pop up a bar with network info: interface name for your connection to the internet (i.e. which has your primary gateway), ip address, netmask, gateway and if you're on a wifi connection your essid and signal strength.

elgithubo commented 1 year ago

I will test soon and report back.

elgithubo commented 1 year ago

Building works fine, but it fails on execution:

elgrande@elfreebsdo:~/git/sfwbar % build/sfwbar -f ./network.config

(sfwbar:3357): GLib-CRITICAL **: 17:25:54.147: g_strlcpy: assertion 'src != NULL' failed
GLib (gthread-posix.c): Unexpected error from C library during 'pthread_mutex_lock': Resource deadlock avoided.  Aborting.
Abbruch
elgrande@elfreebsdo:~/git/sfwbar %

Does that ring a bell?

LBCrion commented 1 year ago

Yes, I think I found a bug here. Can you try again please? You just go to the directory you used to check before and run:

git pull
ninja -C build
cp build/libnetwork.so .
./build/sfwbar -f ./network.config
elgithubo commented 1 year ago

20221216_18h57m34s_grim

Looks good! (no SSID since I am connected via LAN). If you want I can make a wifi setup and test that, too (but probably not today anymore).

LBCrion commented 1 year ago

Great! Although, it looks like I need to check the signal call, it should be zero when you're not on WiFi. If you get a chance to test it on a machine with WiFi, I would greatly appreciate it, since that's a piece of code I had to write blind.

On Fri, 16 Dec 2022, 17:59 Tino Engel, @.***> wrote:

[image: 20221216_18h57m34s_grim] https://user-images.githubusercontent.com/15913459/208159753-387977fd-c050-4a9c-950a-c257314936d8.png

Looks good! (no SSID since I am connected via LAN). If you want I can make a wifi setup and test that, too (but probably not today anymore).

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/64#issuecomment-1355321342, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFEAUTDH3NWQVTHA263WNSUW7ANCNFSM6AAAAAASOHAS5Q . You are receiving this because you commented.Message ID: @.***>

elgithubo commented 1 year ago

You obviously have great blind programming skills!

20221218_21h07m37s_grim

LBCrion commented 1 year ago

Hi @elgithubo, I just pushed a fairly major update to the network module. Would you mind testing if it still works if you get a chance please?

elgithubo commented 1 year ago

Hey... I will ping you as soon as I have tested...

elgithubo commented 1 year ago

Hey @LBCrion Still looks great: 20230115_10h02m11s_grim

LBCrion commented 1 year ago

Awesome. Thank you!

On Sun, 15 Jan 2023, 09:05 Tino Engel, @.***> wrote:

Hey @LBCrion https://github.com/LBCrion Still looks great: [image: 20230115_10h02m11s_grim] https://user-images.githubusercontent.com/15913459/212532313-f2b5dd0b-de32-4cec-b18e-d3fcd8873671.png

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/64#issuecomment-1383095680, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFAJGG6XR7M3Z2XSGODWSO4UZANCNFSM6AAAAAASOHAS5Q . You are receiving this because you were mentioned.Message ID: @.***>

elgithubo commented 1 year ago

1beta_v10 seems to work great here at a first glance. Thanks!

LBCrion commented 1 year ago

Thank you for testing! This one would be a bit trickier to package. This version introduces modules (as you know, since you've tested them!), so it has optional buildtime and runtime dependencies. I think FreeBSD ports allow controlling these at build time? The features are:

network - this one has no dependencies pulse - depends on libpulse and libpulse-mainloop-glib mpd - depends on libmpdclient xkbmap - depends on libxkbcommon

LBCrion commented 1 year ago

Looking at FreeBSD ports, I think the Makefile for 1.0_beta10 should look something like this:

PORTNAME=       sfwbar
DISTVERSION=    1.0_beta10
DISTVERSIONPREFIX=      v
PORTREVISION=   1
CATEGORIES=     x11 wayland

MAINTAINER=     tino.engel@mail.de
COMMENT=        Flexible taskbar application for wayland compositors
WWW=            https://github.com/LBCrion/sfwbar

LICENSE=        GPLv3
LICENSE_FILE=   ${WRKSRC}/LICENSE

BUILD_DEPENDS=  wayland-protocols>0:graphics/wayland-protocols
LIB_DEPENDS=    libgtk-layer-shell.so:x11-toolkits/gtk-layer-shell \
                libwayland-client.so:graphics/wayland \
                libjson-c.so:devel/json-c

USES=           gnome meson pkgconfig
USE_GNOME=      cairo gdkpixbuf2 gtk30

USE_GITHUB=     yes
GH_ACCOUNT=     LBCrion

OPTIONS_DEFINE=         MPD NETWORK PULSEAUDIO XKB
OPTIONS_DEFAULT=        MPD NETWORK PULSEAUDIO XKB

MPD_DESC=               Music player daemon control
MPD_LIB_DEPENDS=        libmpdclient.so:audio/libmpdclient
MPD_MESON_ENABLED=      mpd

NETWORK_DESC=           Network interface monitor support
NETWORK_MESON_ENABLED=  network

PULSEAUDIO_DESC=                Pulse audio volume control
PULSEAUDIO_LIB_DEPENDS=         libpulse.so:audio/pulseaudio
PULSEAUDIO_MESON_ENABLED=       pulse

XKB_DESC=               XkbCommon keyboard layout conversion support
XKB_LIB_DEPENDS=        libxkbregistry.so:x11/libxkbcommon
XKB_MESON_ENABLED=      xkb

SUB_FILES=      pkg-message

.include <bsd.port.mk>

Please treat this with care, I don't have a system to test this on.

elgithubo commented 1 year ago

Sorry was covered by Apple Music not working for me, will read it later.

elgithubo commented 1 year ago

Im am sorry to say, but the Makefile looks erroneous to me. If you want to write such a Makefile, imho you should at least install FreeBSD in a VM. You do not need to, since I can take care of the porting anyhow.

LBCrion commented 1 year ago

I'll leave it to you then. My FreeBSD vm is a bit too limited to install all the necessary dependencies, so any testing will be a bit too theoretical.

On Thu, 16 Mar 2023, 05:46 Tino Engel, @.***> wrote:

Im am sorry to say, but the Makefile looks erroneous to me. If you want to write such a Makefile, imho you should at least install FreeBSD in a VM. You do not need to, since I can take care of the porting anyhow.

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/64#issuecomment-1471356288, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFCS3UKEGKABO62IF3TW4KSL7ANCNFSM6AAAAAASOHAS5Q . You are receiving this because you were mentioned.Message ID: @.***>

elgithubo commented 1 year ago

I will update the port, but it may take some time. Sorry!

elgithubo commented 1 year ago

The port has been updated, but it does not work. Maybe the executable source code is not included in the compilation.

LBCrion commented 1 year ago

Which parts aren't working? The parts that are new in this version are modules, so in theory if you just bump the version on the old package, it should build and work, but module functionality will be missing. To build modules, we need to add dependencies listed above and enable the features in meson (i.e. -Dmpd=enabled -Dpulse=enabled -Dnetwork=enabled -Dxkb=enabled). Unless I'm mistaken, in FreeBSD ports this is set via MESON_ENABLED flag (i.e. MESON_ENABLED= mpd pulse network xkb).

Once modules are built, they will need to be added to file list, they should be in the sfwbar subdirectory in the lib directory.I think on FreeBSD that should be /usr/local/lib/sfwbar/

There should be 4 files in there: mpd.so, pulsectl.so, network.so and xkb.so

Ideally the 4 plugins should be build time optional to avoid forcing all users install dependencies for these even if they don't use them. (i.e. users using sndio, may not want to install pulse libs).

This is what I tried to accomplish above and failed spectacularly :/

Do you have your prototype port posted somewhere? I can try to have a look and see if I can spot anything.

elgithubo commented 1 year ago

The sfwbar executable is missing.

LBCrion commented 1 year ago

That's odd. The executable installation should be unchanged since the last version. Does meson install the executable? You can check with:

meson build ninja -C build cd build mkdir tmp DESTDIR=$pwd/tmp meson install And check if sfwbar is installed in tmp/usr/local/bin

On Sat, 18 Mar 2023, 06:11 Tino Engel, @.***> wrote:

The sfwbar executable is missing.

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/64#issuecomment-1474741940, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFATJWI7UDZG5QNOOC3W4VGXTANCNFSM6AAAAAASOHAS5Q . You are receiving this because you were mentioned.Message ID: @.***>

LBCrion commented 1 year ago

I beefed up my FreeBSD VM and the following Makefile and plist work (the rest of the files are unchanged from your beta9 port):

Makefile:

DISTVERSION=    1.0_beta10
DISTVERSIONPREFIX=      v
PORTREVISION=   1
CATEGORIES=     x11 wayland

MAINTAINER=     tino.engel@mail.de
COMMENT=        Flexible taskbar application for wayland compositors
WWW=            https://github.com/LBCrion/sfwbar

LICENSE=        GPLv3
LICENSE_FILE=   ${WRKSRC}/LICENSE

BUILD_DEPENDS=  wayland-protocols>0:graphics/wayland-protocols
LIB_DEPENDS=    libgtk-layer-shell.so:x11-toolkits/gtk-layer-shell \
                libwayland-client.so:graphics/wayland \
                libjson-c.so:devel/json-c

USES=           gnome meson pkgconfig
USE_GNOME=      cairo gdkpixbuf2 gtk30

USE_GITHUB=     yes
GH_ACCOUNT=     LBCrion

OPTIONS_DEFINE=         MPD NETWORK PULSEAUDIO XKB
OPTIONS_DEFAULT=        MPD NETWORK PULSEAUDIO XKB
OPTIONS_SUB=            yes

MPD_DESC=               Music player daemon control
MPD_LIB_DEPENDS=        libmpdclient.so:audio/libmpdclient
MPD_MESON_ENABLED=      mpd

NETWORK_DESC=           Network interface monitor support
NETWORK_MESON_ENABLED=  network

PULSEAUDIO_DESC=                Pulse audio volume control
PULSEAUDIO_LIB_DEPENDS=         libpulse.so:audio/pulseaudio
PULSEAUDIO_MESON_ENABLED=       pulse

XKB_DESC=               XkbCommon keyboard layout conversion support
XKB_LIB_DEPENDS=        libxkbregistry.so:x11/libxkbcommon
XKB_MESON_ENABLED=      xkb

SUB_FILES=      pkg-message

.include <bsd.port.mk>

pkg-plist:

bin/sfwbar
man/man1/sfwbar.1.gz
man/man1/sfwbar-pulse.1.gz
man/man1/sfwbar-mpd.1.gz
man/man1/sfwbar-network.1.gz
man/man1/sfwbar-xkbmap.1.gz
%%DATADIR%%/battery-svg.widget
%%DATADIR%%/battery.widget
%%DATADIR%%/clock.widget
%%DATADIR%%/cpu-temp.widget
%%DATADIR%%/cpu.widget
%%DATADIR%%/fan-rpm.widget
%%DATADIR%%/idle.widget
%%DATADIR%%/lan-bps.widget
%%DATADIR%%/mb-temp.widget
%%DATADIR%%/memory.widget
%%DATADIR%%/mpd-mini.widget
%%DATADIR%%/mpd-module.widget
%%DATADIR%%/mpd.widget
%%DATADIR%%/network-module.widget
%%DATADIR%%/oneline.config
%%DATADIR%%/pulse-module.widget
%%DATADIR%%/sfwbar.config
%%DATADIR%%/showdesktop.widget
%%DATADIR%%/startmenu.widget
%%DATADIR%%/icons/weather/LICENSE
%%DATADIR%%/icons/weather/clearsky_day.svg
%%DATADIR%%/icons/weather/clearsky_night.svg
%%DATADIR%%/icons/weather/clearsky_polartwilight.svg
%%DATADIR%%/icons/weather/cloudy.svg
%%DATADIR%%/icons/weather/fair_day.svg
%%DATADIR%%/icons/weather/fair_night.svg
%%DATADIR%%/icons/weather/fair_polartwilight.svg
%%DATADIR%%/icons/weather/fog.svg
%%DATADIR%%/icons/weather/heavyrain.svg
%%DATADIR%%/icons/weather/heavyrainandthunder.svg
%%DATADIR%%/icons/weather/heavyrainshowers_day.svg
%%DATADIR%%/icons/weather/heavyrainshowers_night.svg
%%DATADIR%%/icons/weather/heavyrainshowers_polartwilight.svg
%%DATADIR%%/icons/weather/heavyrainshowersandthunder_day.svg
%%DATADIR%%/icons/weather/heavyrainshowersandthunder_night.svg
%%DATADIR%%/icons/weather/heavyrainshowersandthunder_polartwilight.svg
%%DATADIR%%/icons/weather/heavysleet.svg
%%DATADIR%%/icons/weather/heavysleetandthunder.svg
%%DATADIR%%/icons/weather/heavysleetshowers_day.svg
%%DATADIR%%/icons/weather/heavysleetshowers_night.svg
%%DATADIR%%/icons/weather/heavysleetshowers_polartwilight.svg
%%DATADIR%%/icons/weather/heavysleetshowersandthunder_day.svg
%%DATADIR%%/icons/weather/heavysleetshowersandthunder_night.svg
%%DATADIR%%/icons/weather/heavysleetshowersandthunder_polartwilight.svg
%%DATADIR%%/icons/weather/heavysnow.svg
%%DATADIR%%/icons/weather/heavysnowandthunder.svg
%%DATADIR%%/icons/weather/heavysnowshowers_day.svg
%%DATADIR%%/icons/weather/heavysnowshowers_night.svg
%%DATADIR%%/icons/weather/heavysnowshowers_polartwilight.svg
%%DATADIR%%/icons/weather/heavysnowshowersandthunder_day.svg
%%DATADIR%%/icons/weather/heavysnowshowersandthunder_night.svg
%%DATADIR%%/icons/weather/heavysnowshowersandthunder_polartwilight.svg
%%DATADIR%%/icons/weather/lightrain.svg
%%DATADIR%%/icons/weather/lightrainandthunder.svg
%%DATADIR%%/icons/weather/lightrainshowers_day.svg
%%DATADIR%%/icons/weather/lightrainshowers_night.svg
%%DATADIR%%/icons/weather/lightrainshowers_polartwilight.svg
%%DATADIR%%/icons/weather/lightrainshowersandthunder_day.svg
%%DATADIR%%/icons/weather/lightrainshowersandthunder_night.svg
%%DATADIR%%/icons/weather/lightrainshowersandthunder_polartwilight.svg
%%DATADIR%%/icons/weather/lightsleet.svg
%%DATADIR%%/icons/weather/lightsleetandthunder.svg
%%DATADIR%%/icons/weather/lightsleetshowers_day.svg
%%DATADIR%%/icons/weather/lightsleetshowers_night.svg
%%DATADIR%%/icons/weather/lightsleetshowers_polartwilight.svg
%%DATADIR%%/icons/weather/lightsnow.svg
%%DATADIR%%/icons/weather/lightsnowandthunder.svg
%%DATADIR%%/icons/weather/lightsnowshowers_day.svg
%%DATADIR%%/icons/weather/lightsnowshowers_night.svg
%%DATADIR%%/icons/weather/lightsnowshowers_polartwilight.svg
%%DATADIR%%/icons/weather/lightssleetshowersandthunder_day.svg
%%DATADIR%%/icons/weather/lightssleetshowersandthunder_night.svg
%%DATADIR%%/icons/weather/lightssleetshowersandthunder_polartwilight.svg
%%DATADIR%%/icons/weather/lightssnowshowersandthunder_day.svg
%%DATADIR%%/icons/weather/lightssnowshowersandthunder_night.svg
%%DATADIR%%/icons/weather/lightssnowshowersandthunder_polartwilight.svg
%%DATADIR%%/icons/weather/partlycloudy_day.svg
%%DATADIR%%/icons/weather/partlycloudy_night.svg
%%DATADIR%%/icons/weather/partlycloudy_polartwilight.svg
%%DATADIR%%/icons/weather/rain.svg
%%DATADIR%%/icons/weather/rainandthunder.svg
%%DATADIR%%/icons/weather/rainshowers_day.svg
%%DATADIR%%/icons/weather/rainshowers_night.svg
%%DATADIR%%/icons/weather/rainshowers_polartwilight.svg
%%DATADIR%%/icons/weather/rainshowersandthunder_day.svg
%%DATADIR%%/icons/weather/rainshowersandthunder_night.svg
%%DATADIR%%/icons/weather/sleet.svg
%%DATADIR%%/icons/weather/rainshowersandthunder_polartwilight.svg
%%DATADIR%%/icons/weather/sleetandthunder.svg
%%DATADIR%%/icons/weather/sleetshowers_day.svg
%%DATADIR%%/icons/weather/sleetshowers_night.svg
%%DATADIR%%/icons/weather/sleetshowers_polartwilight.svg
%%DATADIR%%/icons/weather/sleetshowersandthunder_day.svg
%%DATADIR%%/icons/weather/sleetshowersandthunder_night.svg
%%DATADIR%%/icons/weather/sleetshowersandthunder_polartwilight.svg
%%DATADIR%%/icons/weather/snow.svg
%%DATADIR%%/icons/weather/snowandthunder.svg
%%DATADIR%%/icons/weather/snowshowers_day.svg
%%DATADIR%%/icons/weather/snowshowers_night.svg
%%DATADIR%%/icons/weather/snowshowers_polartwilight.svg
%%DATADIR%%/icons/weather/snowshowersandthunder_day.svg
%%DATADIR%%/icons/weather/snowshowersandthunder_night.svg
%%DATADIR%%/icons/weather/snowshowersandthunder_polartwilight.svg
%%DATADIR%%/icons/misc/comp.svg
%%DATADIR%%/icons/misc/cpu.svg
%%DATADIR%%/icons/misc/fan.svg
%%DATADIR%%/icons/misc/fforward.svg
%%DATADIR%%/icons/misc/lan.svg
%%DATADIR%%/icons/misc/lock.svg
%%DATADIR%%/icons/misc/missing.svg
%%DATADIR%%/icons/misc/music-player-symbolic.svg
%%DATADIR%%/icons/misc/play.svg
%%DATADIR%%/icons/misc/rewind.svg
%%DATADIR%%/icons/misc/stop.svg
%%DATADIR%%/icons/misc/unlock.svg
%%DATADIR%%/sway-lang.widget
%%DATADIR%%/t2.config
%%DATADIR%%/twoline.config
%%DATADIR%%/usage.widget
%%DATADIR%%/vertical.config
%%DATADIR%%/w10.config
%%DATADIR%%/wbar.config
%%DATADIR%%/weather.widget
share/icons/hicolor/scalable/apps/sfwbar.svg
%%NETWORK%%lib/sfwbar/network.so
%%PULSEAUDIO%%lib/sfwbar/pulsectl.so
%%MPD%%lib/sfwbar/mpd.so
%%XKB%%lib/sfwbar/xkbmap.so
elgithubo commented 1 year ago

Hey, sorry for the delay, I am currently in hospital and do not have my FreeBSD compatible WiFi stick with me. As soon as I am able to, I will continue working on this.

LBCrion commented 1 year ago

No problem at all. Hope it's nothing serious!

On a positive side, the next version should include the bsdctl module, which should bring BSD support in sfwbar up to par with linux (I.e cpu, memory, battery widgets etc).

On Thu, 30 Mar 2023, 06:02 Tino Engel, @.***> wrote:

Hey, sorry for the delay, I am currently in hospital and do not have my FreeBSD compatible WiFi stick with me. As soon as I am able to, I will continue working on this.

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/64#issuecomment-1489697540, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFDIBW7HYA3F7DSY5S3W6UHXLANCNFSM6AAAAAASOHAS5Q . You are receiving this because you were mentioned.Message ID: @.***>

elgithubo commented 1 year ago

No, fortunately nothing serious. I will update the port asap. Although I am looking forward to he next version, too.

LBCrion commented 1 year ago

Great to hear. For the beta10 port, we should probably add a patch from 47c37b4d634d834287c5cc1da948e643d61b0847, as it fixes a crash bug.

elgithubo commented 1 year ago

Unfortunately I cannot add single commits to a FreeBSD port. Ports normally require to be based on a release (that's also what the GitHub port framework supports).

LBCrion commented 1 year ago

I think it should be possible to apply just the commit as a patch in the port. the commit itself is a patch file, so need to save the contents of the commit to file/sfwbar_modules_network.c and then add this file to the port using PATCHFILES option (at least if I read section 4.4 of porters manual correctly).

elgithubo commented 1 year ago

You are insofar right, that this should be a technical possibility. Anyhow the standard procedure is to stick to official releases, since otherwise it gets complex e.g. regarding the version scheme.

When is beta11 coming?

LBCrion commented 1 year ago

I'm hoping soon, but I'd like to get track down #86 before releasing.

elgithubo commented 1 year ago

Great, so I'll wait.

Gr33z

P.S.: FreeBSD port patches are not meant for adding upstream patches, but in order to apply FreeBSD-specific patches for software that does not run on FreeBSD with adjustments

LBCrion commented 1 year ago

@elgithubo , can you please try the latest git version on FreeBSD and see if CPU, memory and battery modules are working for you?

LBCrion commented 1 year ago

Oh, and you'll need to configure the source with meson -Dbsdctl=enabled build to enable the new BSD functionality.

elgithubo commented 1 year ago

Will be still in hospital for some time.

LBCrion commented 1 year ago

Wish you a speedy recovery!

On Fri, 28 Apr 2023, 18:48 Tino Engel, @.***> wrote:

Will be still in hospital for some time.

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/64#issuecomment-1527894879, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFGDZA62GB6AZDG2FOTXDP7HZANCNFSM6AAAAAASOHAS5Q . You are receiving this because you were mentioned.Message ID: @.***>

elgithubo commented 1 year ago

Thx

elgithubo commented 1 year ago

@LBCrion just want to let you know, that I still have no access to a FreeBSD device, now that beta11 is out.

elgithubo commented 1 year ago

@LBCrion at it now, maybe you wanna check BAD CAN||CON on Discord?

LBCrion commented 1 year ago

Alas, I'm a dinosaur who has never used Discord. Still on IRC! CrazyLion in #linuxlounge on libera-chat, but I'm very rarely actually around.

I think the port in my post from March 19th, shouldn't need many changes with beta 11. Need to add MESON_ARGS += -Dbsdctl to the Makefile and update file list to add lib/sfwbar/bsdctl.so and some new config files in the new version. And update the version of course!

Unfortunately my laptop has died I haven't gotten a FreeBSD VM working on my new one yet, so can't test it here.

elgithubo commented 1 year ago

info@LBCrion

Might that solve my current error?


root@server1b /p/x/sfwbar (main) [1]# make
===>  License GPLv3 accepted by the user
===>   sfwbar-1.0.b11_1 depends on file: /usr/local/sbin/pkg - found
=> LBCrion-sfwbar-v1.0_beta11_GH0.tar.gz is not in /ports/x11/sfwbar/distinfo.
=> Either /ports/x11/sfwbar/distinfo is out of date, or
=> LBCrion-sfwbar-v1.0_beta11_GH0.tar.gz is spelled incorrectly.
*** Error code 1

Stop.
make: stopped in /ports/x11/sfwbar
root@server1b /p/x/sfwbar (main) [1]#

I cannot get rid of the _GH0 despite

root@server1b /p/x/sfwbar (main) [1]# grep -r GH0 *
root@server1b /p/x/sfwbar (main) [1]#

Do you have any idea?

LBCrion commented 1 year ago

No, this looks like an issue with the distinfo file. _GH0 is automatically added by port tools for sources from github. Distinfo file should be generated accordingly, this should be automatic. Do you need to regenerate distinfo maybe if one already exists?

On Sat, 20 May 2023, 16:57 Tino Engel, @.***> wrote:

@.***

Might that solve my current error?

@. /p/x/sfwbar (main) [1]# make ===> License GPLv3 accepted by the user ===> sfwbar-1.0.b11_1 depends on file: /usr/local/sbin/pkg - found => LBCrion-sfwbar-v1.0_beta11_GH0.tar.gz is not in /ports/x11/sfwbar/distinfo. => Either /ports/x11/sfwbar/distinfo is out of date, or => LBCrion-sfwbar-v1.0_beta11_GH0.tar.gz is spelled incorrectly. Error code 1

Stop. make: stopped in /ports/x11/sfwbar @.*** /p/x/sfwbar (main) [1]#

I cannot get rid of the _GH0 despite

@. /p/x/sfwbar (main) [1]# grep -r GH0 **@.*** /p/x/sfwbar (main) [1]#

Do you have any idea?

— Reply to this email directly, view it on GitHub https://github.com/LBCrion/sfwbar/issues/64#issuecomment-1555941091, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHPFFEEXD3WSFCRM7R766LXHDSU5ANCNFSM6AAAAAASOHAS5Q . You are receiving this because you were mentioned.Message ID: @.***>

elgithubo commented 1 year ago

I could build the updated port now but need more cloud space in order to create a pr.

elgithubo commented 1 year ago

Again at the GH0 problem, now with disc space. 🙄

LBCrion commented 1 year ago

Hmm... did you manage to fix it by regenerating distinfo or by some other means?