search

LBHB / NEMS0

THIS VERSION OF NEMS IS NO LONGER SUPPORTED. PLEASE USE THE NEW NEMS REPOSITORY OR INSTALL NEMS_DB TO GET NEMS0 SUPPORT.
GNU General Public License v3.0
8 stars 4 forks source link

bug in remove_overlap from epoch.py? #64

Closed crheller closed 6 years ago

crheller commented 6 years ago

If given an array of segments: [ [0 1.5], [1.5, 3] ] this function (remove_overlap) returns only [ [1 1.5] ]. Is this the desired performance? I would vote no. I'd think it would return [ [0 1.5], [1.5, 3] ] in this case. But I don't know where else this is used/what it was implemented for...

crheller commented 6 years ago

So, in this part of the code: while (i < n) and (ub >= a[i, 0])

I think (ub >= a[i, 0]) should be (ub > a[i, 0])

lshaheen commented 6 years ago

I think this is fixed, see pr #63

crheller commented 6 years ago

Ah... it appears I need to pull master haha thanks

bburan commented 6 years ago

Or rebase per Christian's suggestion?

On Wed, Apr 11, 2018 at 7:12 PM, crheller notifications@github.com wrote:

Closed #64 https://github.com/LBHB/NEMS/issues/64.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LBHB/NEMS/issues/64#event-1569949693, or mute the thread https://github.com/notifications/unsubscribe-auth/AAT5QuE9cbVM_oNVGf65pfCVMTvkF_gIks5tnrf7gaJpZM4TQ63c .