search

LBHB / NEMS0

THIS VERSION OF NEMS IS NO LONGER SUPPORTED. PLEASE USE THE NEW NEMS REPOSITORY OR INSTALL NEMS_DB TO GET NEMS0 SUPPORT.
GNU General Public License v3.0
8 stars 4 forks source link

Add documentation for FIR filter banks #82

Closed bburan closed 6 years ago

bburan commented 6 years ago

There is absolutely no in-line documentation (i.e., comments) or docstrings that explain how FIR filter banks work. Would be helpful to understand the shape of x and coefficients when bank_count == 1 and when bank_count > 1.

svdavid commented 6 years ago

aha! added to the normalization branch. along with about a million other smaller changes... I don't think they mess with anything too critical, so I set up a pull request to master.

bburan commented 6 years ago

Thanks. The shapes make sense now!

From: Stephen D [notifications@github.com] Sent: Thursday, May 17, 2018 1:53 PM To: LBHB/NEMS Cc: Brad Buran; Author Subject: Re: [LBHB/NEMS] Add documentation for FIR filter banks (#82)

aha! added to the normalization branch. along with about a million other smaller changes... I don't think they mess with anything too critical, so I set up a pull request to master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LBHB/NEMS/issues/82#issuecomment-390008006, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAT5QvUrSYpiwh_NN66LVFsNP98PZYNqks5tzeNfgaJpZM4UDueE.

svdavid commented 6 years ago

Think we can close this?